Skip to content

Change our new arch cpp-lib template to align with the RN "golden" template #13250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jonthysell opened this issue May 20, 2024 · 3 comments
Closed
Labels
Area: Library Template enhancement New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric Old Architecture Broad category for issues that apply to the RN "old" architecture of Cxx Modules + Paper Workstream: Module Support Module developers have the requisite tooling and clear path for adding windows support to modules.
Milestone

Comments

@jonthysell
Copy link
Contributor

Summary

There's a (still in progress at the time of opening this) RFC to create a specific official "golden" template for RN libraries, being discussed here: react-native-community/discussions-and-proposals#721

Specifics may change, but so far it looks like:

  • New and Old Arch support
  • Includes both a native module and a native view component
  • Uses TypeScript
  • Android/iOS provided by Java and ObjC

You can see the details here: https://github.com/react-native-community/discussions-and-proposals/pull/721/files#diff-3e529b09f72e10925002030c7234cea4ff1fcfff33aea495328c58e8b4518955

Motivation

When the output of this RFC becomes the official template, we'll want to pivot onto it for our template, because we can't possibly support every variation of libraries that have evolved in the community, we'll build on the standard and let others standardize their code or adapt ours.

Basic Example

No response

Open Questions

No response

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label May 20, 2024
@jonthysell jonthysell added Old Architecture Broad category for issues that apply to the RN "old" architecture of Cxx Modules + Paper New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels May 20, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) label May 21, 2024
@jonthysell jonthysell added this to the Next milestone Aug 28, 2024
@jonthysell jonthysell self-assigned this Aug 28, 2024
@jonthysell jonthysell removed the Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) label Aug 28, 2024
@jonthysell
Copy link
Contributor Author

It looks like the create-react-native-library command now has a --with-recommended-options to pick the recommended template to build.

@jonthysell jonthysell assigned marlenecota and unassigned jonthysell Aug 28, 2024
@jonthysell
Copy link
Contributor Author

@marlenecota As you're working on the new "joint" lib template for all-in-one old+new arch support, you should make sure it's based on top of the correct starting RN lib template with the recommended options in the previous comment (which IIRC is in fact new + old arch support)

@chrisglein chrisglein modified the milestones: Next, 0.76 Sep 25, 2024
@chiaramooney chiaramooney added the Workstream: Module Support Module developers have the requisite tooling and clear path for adding windows support to modules. label Oct 3, 2024
@chrisglein chrisglein assigned jonthysell and unassigned marlenecota Oct 9, 2024
@chrisglein chrisglein modified the milestones: 0.76, Next Nov 6, 2024
@chrisglein chrisglein modified the milestones: Next, Backlog Dec 18, 2024
@jonthysell jonthysell removed their assignment Mar 12, 2025
@jonthysell
Copy link
Contributor Author

This template existed for a hot minute then was removed, and hasn't materialized. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Library Template enhancement New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric Old Architecture Broad category for issues that apply to the RN "old" architecture of Cxx Modules + Paper Workstream: Module Support Module developers have the requisite tooling and clear path for adding windows support to modules.
Projects
Status: Done
Development

No branches or pull requests

4 participants