Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

debug test.py not limiting test output in debug mode - facilitates faster build runtimes #331

Open
maxkazmsft opened this issue May 28, 2020 · 0 comments
Labels
Prior: High Type: Bug Something isn't working Type: Enhancement This an enhancement to an existing feature

Comments

@maxkazmsft
Copy link
Contributor

maxkazmsft commented May 28, 2020

Too many images are being added to the test1 split dump in test.py – we should not be scoring the entire batch with debug flag with the code in test.py

    if debug:
        logger.info("Running in Debug/Test mode")
        test_loader = take(2, test_loader)

but somehow we are doing this anyway.

Make sure that we understand this behaviour, as with even 2 slices and slicing in the inline direction, we should not have so many patches which are dumped for scoring. This could be related to #330 as if we're scoring too many empty and largely padded patches, this functionality is not needed.

Restructuing: potentially remove "if debug" and subset the data for tests across the board.

@maxkazmsft maxkazmsft added Type: Bug Something isn't working Prior: High Type: Correctness anything to do with repo being technically correct labels May 28, 2020
@maxkazmsft maxkazmsft added this to the V0.1.3 [BYOD] milestone May 28, 2020
@maxkazmsft maxkazmsft added Type: Enhancement This an enhancement to an existing feature and removed Type: Correctness anything to do with repo being technically correct labels May 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Prior: High Type: Bug Something isn't working Type: Enhancement This an enhancement to an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant