Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bash on Ubuntu on Windows drawing issues while resizing window #30

Closed
Tracked by #8000
SilviuArdelean opened this issue Sep 12, 2017 · 5 comments
Closed
Tracked by #8000
Labels
Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Conhost For issues in the Console codebase

Comments

@SilviuArdelean
Copy link

Updating a Raspberry Pi with Raspbian OS using 'apt' via SSH in Bash for Windows and resizing the window during the upgrade phase (sudo apt upgrade -y) seems to have rows drawing issues.

I was able to reproduce it also within my Bash sub-system while upgrading it.

clipboard01_bash_resize_while_updating_apt
clipboard02_bash_resize_while_upgrading_apt
clipboard03_bash_resize_while_upgrading_apt
clipboard04_bash_resize_while_upgrading_apt

@zadjii-msft zadjii-msft added Product-Conhost For issues in the Console codebase Work-Item It's being tracked by an actual work item internally. (to be removed soon) labels Sep 13, 2017
@zadjii-msft
Copy link
Member

zadjii-msft commented Sep 13, 2017

I can confirm that this is in fact happening. I can understand why it's happening, given the current workings of the console. However, I don't think a fix would be super easy. I believe this has something to do with the Console reflowing the text after a resize event. We keep redrawing the buffer every time the size changes, and then apt is also redrawing on top of that, and everyone gets confused. We might be able to defer reflowing until the resize has stopped, but that might not resolve the problem entirely, and might make it worse.

I'll add it to my bug backlog either way.

@noscript
Copy link

The problem has probably something do with recognizing \r or ^H.

@zadjii-msft zadjii-msft added Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. and removed Work-Item It's being tracked by an actual work item internally. (to be removed soon) labels Nov 28, 2017
@zadjii-msft
Copy link
Member

So, I've taken a closer look at this. I believe the "Right Way" to fix this is to implement a more unix-y buffer. Unfortunately that's a little bit bigger of a task then we can get done for the next release, but (without committing to anything) we do have work planned in that area.

In the meantime, I'm replacing the "bug" label with the "feature" label - still on our radar, just a little bit farther out.

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label May 17, 2019
@miniksa miniksa added the Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) label May 29, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label May 29, 2019
@mominshaikhdevs
Copy link

Can this issue be closed now that #8000 is closed?

@lhecker lhecker added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jul 8, 2024
@carlos-zamora
Copy link
Member

Yeah, now that #8000 is done, we think that this is as good as it gets. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Output Related to output processing (inserting text into buffer, retrieving buffer text, etc.) Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Conhost For issues in the Console codebase
Projects
None yet
Development

No branches or pull requests

8 participants