Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two questions about Arabic and right-to-left text #8826

Closed
vefatica opened this issue Jan 19, 2021 · 7 comments
Closed

Two questions about Arabic and right-to-left text #8826

vefatica opened this issue Jan 19, 2021 · 7 comments
Labels
Issue-Question For questions or discussion Needs-Tag-Fix Doesn't match tag requirements Resolution-Answered Related to questions that have been answered

Comments

@vefatica
Copy link

I Google for "hello Arabic". I get the usual translation dialog and press the "copy" button.
image
I paste to a TCC command line in WT ...
image
Two questions:
CHARMAP doesn't show any Arabic characters for my font (Consolas). Where are they coming from?

If I backspace, those pasted characters are deleted from the left end! Who (what software) knows (and how) that it's right-to-left?

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jan 19, 2021
@DHowett
Copy link
Member

DHowett commented Jan 19, 2021

Terminal implements font fallback (using DirectWrite); those characters are pulled from somewhere (but we do not surface the source anywhere.)

That RTL script is rendered properly (RTL) is an artifact of our renderer, and cannot be relied-upon or trusted until #538 lands. 😄

@DHowett DHowett added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Jan 19, 2021
@DHowett
Copy link
Member

DHowett commented Jan 19, 2021

That artifact is "we give DirectWrite runs of glyphs that are all the same color; it calculates how to render them itself". It's lucky that it works out as well as it does sometimes.

@vefatica
Copy link
Author

Thanks!

we do not surface the source

Can't ... won't?

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Jan 19, 2021
@DHowett
Copy link
Member

DHowett commented Jan 19, 2021

Don't see the need to, don't have a place to do it, don't think anyone cares. 😄

We're not a word processor. You can't just put your cursor on something and ask what font it came out in. There's no additional side channel for us to express that info with, either.

Oh, open a debug tap, "we rendered the glyph at 6, 7 using NSimSun instead of Consolas". Okay, who's going to use that information and for what purpose? 😄

@DHowett DHowett added Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something and removed Needs-Attention The core contributors need to come back around and look at this ASAP. labels Jan 19, 2021
@vefatica
Copy link
Author

Just curious about how things work.

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels Jan 19, 2021
@mdtauk
Copy link

mdtauk commented Jan 19, 2021

Just a curiosity of mine. For Right to Left, how is the command prompt handled?

|                                                  output  |
|                                                          |
|                                                 █  </:C  |
____________________________________________________________

@DHowett
Copy link
Member

DHowett commented Jan 19, 2021

how.. handled

It's not. It's not handled. Definitely move this discussion over to #538 if you'd like to talk RTL details.

@DHowett DHowett closed this as completed Jan 19, 2021
@DHowett DHowett added Issue-Question For questions or discussion Resolution-Answered Related to questions that have been answered and removed Needs-Attention The core contributors need to come back around and look at this ASAP. Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Jan 19, 2021
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Question For questions or discussion Needs-Tag-Fix Doesn't match tag requirements Resolution-Answered Related to questions that have been answered
Projects
None yet
Development

No branches or pull requests

3 participants