Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model Factory doesn't pass additional properties arg to full constructor if full constructor was customized #5107

Open
JoshLove-msft opened this issue Nov 14, 2024 · 0 comments · May be fixed by #5108
Assignees
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp

Comments

@JoshLove-msft
Copy link
Contributor

Due to the changes in #5082 re: ordering of constructor parameters, the logic in ModelFactoryProvider was updated to no longer assume that additionalBinaryDataProperties was the last parameter. Doing this uncovered an issue where if the full provider was customized to have the same number of parameters as the generated one, we wouldn't end up using the customized full constructor in the model factory. We need to update the logic to replace the full constructor even when the number of parameters are the same.

@JoshLove-msft JoshLove-msft added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label Nov 14, 2024
@JoshLove-msft JoshLove-msft self-assigned this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant