Workflow test: CoR debug instruction review by MicroFish91 · Pull Request #1905 · microsoft/vscode-azureresourcegroups

Matthew Fisher (MicroFish91) · 2026-09-22T20:23:42Z

Not a real PR, just testing stuff, don't review it if you're a real person

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Matthew Fisher (MicroFish91) · 2026-09-22T21:25:33Z

/cor-debug-generate-review

Matthew Fisher (MicroFish91) · 2026-09-22T22:04:26Z

/cor-debug-generate-review

Matthew Fisher (MicroFish91) · 2026-09-22T22:27:06Z

/cor-debug-generate-review

Matthew Fisher (MicroFish91) · 2026-09-23T16:26:12Z

/cor-debug-generate-review

Matthew Fisher (MicroFish91) · 2026-09-23T16:37:39Z

/cor-debug-generate-review

Copilot

Copilot review overview

🟡 Changes recommended

Refresh evals/agent-assets.lock.json to satisfy the agent drift check.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1

Open (1)

Refresh agent asset lockfile after instruction change · New

What changed in this PR

Updates the Azure debug generation instructions for clearer reference-loading guidance and corrected Markdown formatting.

Changes:

Clarifies service selection and reference loading.
Corrects table formatting.
Requires refreshing the agent asset lock.

File	Summary
`resources/agents/azure-debug-generate/instructions.md`	Clarifies reference loading and fixes table formatting.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

 |---|--------|-----------|
 | 1 | **Verify plan** — Confirm `.azure/vscode-debug-plan.md` exists with status `Approved`. Set status to `Executing` and update **Last Updated**. | `.azure/vscode-debug-plan.md` |
-| 2 | **Load references** — For each service in the plan's Services table (where Generate is checked), load the corresponding project-type and runtime reference files. If no reference file exists, emit a limited-support warning. | [limited-support.md](references/limited-support.md) |
+| 2 | **Load references** — For each service with Generate checked in the plan's Services table, load the corresponding project-type and runtime reference files. If no reference file exists, emit a limited-support warning. | [limited-support.md](references/limited-support.md) |


github-actions

CoR debug generation review

These are general recommendations. Treat them as suggestions, not rules that
every change must follow.

Verdict: PASS
Reviewed head: 6af37b0
Compared base: d5513d9

The scoped edit preserves the existing ownership and workflow composition while expressing the same Generate-selection rule more directly.

Findings

None.

Coverage

Inspected scoped file: resources/agents/azure-debug-generate/instructions.md.

AR-01: pass — the shared reference-loading rule remains in the internal workflow instructions.
AR-02: pass — the edit neither duplicates nor redefines the Generate-selection rule.
AR-03: pass — the internal instructions still coordinate project-type and runtime references without absorbing their implementation details.
AR-04: pass — the selected references and limited-support fallback remain explicit.
AR-05: pass — shared selection behavior remains separate from project/runtime-specific behavior.
AR-06: not applicable — no shared module or caller interface changed.
AR-07: not applicable — no orchestrator behavior changed.
AR-08: not applicable — no category entry or template changed.

This is a static instruction review, not a successful F5 or end-to-end test.
After pushing fixes, someone with write, maintain, or admin access to the base
repository can post a new PR comment starting with /cor-debug-generate-review
to request another review.

Generated by CoR Azure Debug Generate Review for #1905 · copilot · gpt56 · 24.9 AIC · ⌖ 14.2 AIC · ⊞ 23.3K
_{Comment /cor-debug-generate-review to run again}

Matthew Fisher (MicroFish91) · 2026-09-24T16:04:31Z

Copilot resolve the merge conflicts in this pull request

…-phase-one # Conflicts: # resources/agents/azure-debug-generate/instructions.md Co-authored-by: MicroFish91 <40250218+MicroFish91@users.noreply.github.com>

Copilot · 2026-09-24T16:06:39Z

Copilot resolve the merge conflicts in this pull request

Merged main into this branch in c397c37. The only conflict was in resources/agents/azure-debug-generate/instructions.md — main rewrote that file into a compacted form, and the Phase 1 row 2 reword from this branch ("For each service with Generate checked in the plan's Services table…") is already conveyed by main's compacted wording ("For each checked Services-table service…"), so I took main's version.

Side effect worth flagging: the branch tree is now identical to main, so this PR currently carries no net diff. npm run eval:drift passes (evals/agent-assets.lock.json is in sync).

Matthew Fisher (MicroFish91) · 2026-09-24T16:21:50Z

/cor-debug-generate-review

github-actions

CoR debug generation review

These are general recommendations. Treat them as suggestions, not rules that
every change must follow.

Verdict: PASS
Reviewed head: b10fdcd
Compared base: ea90e18

The scoped wording change clarifies that limited support depends on the absence of a matching reference and preserves the existing ownership and composition model.

Findings

None.

Coverage

Inspected scoped file: resources/agents/azure-debug-generate/instructions.md.

AR-01: pass — the workflow coordinator still owns reference selection.
AR-02: pass — limited-support detection remains primarily defined by references/limited-support.md.
AR-03: pass — the internal instructions point to the reference without duplicating its detection algorithm.
AR-04: pass — the matching-reference condition and linked warning reference compose explicitly.
AR-05: pass — no implementation-specific behavior moved into shared instructions.
AR-06: not applicable — no shared module was added or changed.
AR-07: pass — the change is orchestrator-neutral and does not alter generation or teardown.
AR-08: not applicable — no category entry or template changed.

Also inspected the unchanged custom agent instructions and references/limited-support.md at the reviewed head for ownership context.

This is a static instruction review, not a successful F5 or end-to-end test.
After pushing fixes, someone with write, maintain, or admin access to the base
repository can post a new PR comment starting with /cor-debug-generate-review
to request another review.

Generated by CoR Azure Debug Generate Review for #1905 · copilot · gpt56 · 26.8 AIC · ⌖ 14.8 AIC · ⊞ 23.8K
_{Comment /cor-debug-generate-review to run again}

Matthew Fisher (MicroFish91) · 2026-09-24T16:41:39Z

/cor-debug-generate-review

github-actions

CoR debug generation review

These are general recommendations. Treat them as suggestions, not rules that
every change must follow.

Verdict: REQUEST CHANGES
Reviewed head: 8e68dcf
Compared base: ea90e18

The Python runtime reference mixes runtime-specific debugger validation with project-type HTTP verification and shared teardown responsibilities.

Findings

AR-01, AR-02 — python.md § Live Validation Checks: Items 3–4 instruct HTTP invocation/skip handling and stopping the Functions host, emulators, and ports. Those behaviors already belong to project-types/functions.md validation signals and validation.md Steps 5–8/final teardown; the runtime template limits this section to debugger-specific checks. This creates competing places to update HTTP and cleanup behavior. Keep the Python worker/debugpy attachment checks here, and remove the generic HTTP/readiness and teardown steps so the existing project-type and validation references remain their sole owners.

Coverage

Inspected scoped files: resources/agents/azure-debug-generate/instructions.md; resources/agents/azure-debug-generate/references/project-types/functions.md; resources/agents/azure-debug-generate/references/runtimes/python.md.

AR-01: request changes — runtime file owns unrelated HTTP and teardown work.
AR-02: request changes — HTTP and cleanup behavior is duplicated across owners.
AR-03: pass — internal instructions remain generic coordination.
AR-04: pass — project-type and runtime references explicitly compose startup, build, and debug output.
AR-05: pass — Python-specific runtime behavior stays separate from Functions host behavior.
AR-06: not applicable — no shared module was introduced.
AR-07: pass — no existing orchestrator behavior is changed.
AR-08: pass — the new runtime entry follows the runtime template's required categories.

This is a static instruction review, not a successful F5 or end-to-end test.
After pushing fixes, someone with write, maintain, or admin access to the base
repository can post a new PR comment starting with /cor-debug-generate-review
to request another review.

Generated by CoR Azure Debug Generate Review for #1905 · copilot · gpt56 · 51.1 AIC · ⌖ 14.9 AIC · ⊞ 23.8K
_{Comment /cor-debug-generate-review to run again}

Matthew Fisher (MicroFish91) · 2026-09-24T19:12:16Z

Done testing, seems to be working as expected

Matthew Fisher (MicroFish91) and others added 15 commits September 21, 2026 16:10

Add the PR reviewer

888abaa

Feedback

c5968cf

Add important comment

dc93b69

Do not run for forks

1d6852f

Some nits

5ceaba7

Update reviewer & rubric.

8faa434

Update model

4e6a7ae

More clear rubric instructions

c8dbabb

More readable reviewer

eae2b5c

Clarify reviewer terminology

b907001

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Clarify rubric introduction

041e7a1

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Simplify rubric overview

a92139b

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Simplify review output format

1279a46

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Merge branch 'main' into microfish91-cor-grading-on-main

8f6a980

Clarify debug reference selection

6ca30e6

Matthew Fisher (MicroFish91) changed the title ~~Test CoR debug instruction review automation - phase 1~~ Workflow test: CoR debug instruction review Sep 22, 2026

Matthew Fisher (MicroFish91) marked this pull request as ready for review September 22, 2026 20:30

Matthew Fisher (MicroFish91) requested a review from a team as a code owner September 22, 2026 20:30

Merge main into CoR review workflow test

778c0b1

Matthew Fisher (MicroFish91) changed the base branch from microfish91-cor-grading-on-main to main September 22, 2026 22:03

Matthew Fisher (MicroFish91) closed this Sep 23, 2026

Matthew Fisher (MicroFish91) reopened this Sep 23, 2026

Merge branch 'main' into microfish91-pr-review-phase-one

ea68db2

Merge branch 'main' into microfish91-pr-review-phase-one

6af37b0

Copilot AI lite review requested due to automatic review settings September 23, 2026 16:37

Copilot started reviewing on behalf of Matthew Fisher (MicroFish91) September 23, 2026 16:37 View session

Copilot AI reviewed Sep 23, 2026

View reviewed changes

github-actions Bot reviewed Sep 23, 2026

View reviewed changes

Matthew Fisher (MicroFish91) closed this Sep 23, 2026

Matthew Fisher (MicroFish91) reopened this Sep 24, 2026

Copilot started work on behalf of Matthew Fisher (MicroFish91) September 24, 2026 16:05 View session

Merge remote-tracking branch 'origin/main' into microfish91-pr-review…

c397c37

…-phase-one # Conflicts: # resources/agents/azure-debug-generate/instructions.md Co-authored-by: MicroFish91 <40250218+MicroFish91@users.noreply.github.com>

Copilot finished work on behalf of Matthew Fisher (MicroFish91) September 24, 2026 16:08

Clarify missing debug reference warning

b10fdcd

github-actions Bot reviewed Sep 24, 2026

View reviewed changes

Document best-effort Python Functions local debugging

8e68dcf

github-actions Bot reviewed Sep 24, 2026

View reviewed changes

Matthew Fisher (MicroFish91) closed this Sep 24, 2026

Conversation

Matthew Fisher (MicroFish91) commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Matthew Fisher (MicroFish91) commented Sep 22, 2026

Uh oh!

Matthew Fisher (MicroFish91) commented Sep 22, 2026

Uh oh!

Matthew Fisher (MicroFish91) commented Sep 22, 2026

Uh oh!

Matthew Fisher (MicroFish91) commented Sep 23, 2026

Uh oh!

Matthew Fisher (MicroFish91) commented Sep 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

CoR debug generation review

Findings

Coverage

Uh oh!

Matthew Fisher (MicroFish91) commented Sep 24, 2026

Uh oh!

Copilot AI commented Sep 24, 2026

Uh oh!

Matthew Fisher (MicroFish91) commented Sep 24, 2026

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

CoR debug generation review

Findings

Coverage

Uh oh!

Matthew Fisher (MicroFish91) commented Sep 24, 2026

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

CoR debug generation review

Findings

Coverage

Uh oh!

Matthew Fisher (MicroFish91) commented Sep 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Matthew Fisher (MicroFish91) commented Sep 22, 2026 •

edited

Loading

Matthew Fisher (MicroFish91) commented Sep 24, 2026 •

edited

Loading