-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revisit use of typedef
linting rule
#10573
Comments
I'm fine with changing the linting rule, but you should wait to see what others think. @WardenGnaw @bobbrow @Colengms @michelleangela |
I'm ok to change the rule. CMake Tools doesn't have it, and I think it's nice not to have to declare types in some cases where it is obvious what it is. |
Yeah, similar to "auto" usage with C++. |
Is there any other feedback on this? Otherwise it sounds like the change should be made and I will open another PR for that. Thanks! |
PR #10559 fails due to linter errors about a lint that probably should not be enabled.
The use of
typedef
lint was added to vscode-cpptools in #1403 with the comment “explicit types is recommended Typescript practice”, but this is not correct. Actually, the documentation for this lint explicitly states the opposite:The compiler is already using the given flags as
strict: true
is set, so I would recommend to remove this lint as it adds line noise and runs against best practices.Let me know your thoughts. Thanks!
The text was updated successfully, but these errors were encountered: