From d3cea4b977f1553eb8e1bad95f582d858e6a2373 Mon Sep 17 00:00:00 2001 From: isidorn Date: Fri, 24 Jan 2025 16:11:14 +0100 Subject: [PATCH 1/2] classify new property --- README.md | 1 + src/common/util.ts | 1 + 2 files changed, 2 insertions(+) diff --git a/README.md b/README.md index 0c19d8b..b75f2d8 100644 --- a/README.md +++ b/README.md @@ -56,6 +56,7 @@ reporter.sendTelemetryErrorEvent('sampleErrorEvent', { 'stringProp': 'some strin - **Extension Version** `common.extversion` - The extension version - **Machine Identifier** `common.vscodemachineid` - A common machine identifier generated by VS Code - **Session Identifier** `common.vscodesessionid` - A session identifier generated by VS Code +- **Machine Identifier** `common.vscodecommithash` - A VS Code commit hash - **VS Code Version** `common.vscodeversion` - The version of VS Code running the extension - **OS** `common.os` - The OS running VS Code - **Platform Version** `common.platformversion` - The version of the OS/Platform diff --git a/src/common/util.ts b/src/common/util.ts index 08a56c5..35c5b81 100644 --- a/src/common/util.ts +++ b/src/common/util.ts @@ -52,6 +52,7 @@ export class TelemetryUtil { // __GDPR__COMMON__ "common.extversion" : { "classification": "PublicNonPersonalData", "purpose": "FeatureInsight" } // __GDPR__COMMON__ "common.vscodemachineid" : { "endPoint": "MacAddressHash", "classification": "EndUserPseudonymizedInformation", "purpose": "FeatureInsight" } // __GDPR__COMMON__ "common.vscodesessionid" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" } + // __GDPR__COMMON__ "common.vscodecommithash" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" } // __GDPR__COMMON__ "common.vscodeversion" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" } // __GDPR__COMMON__ "common.uikind" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" } // __GDPR__COMMON__ "common.remotename" : { "classification": "SystemMetaData", "purpose": "FeatureInsight" } From ecaa1f588d9a00cca09a8e14d58fbdfcaceb8333 Mon Sep 17 00:00:00 2001 From: isidorn Date: Fri, 24 Jan 2025 16:20:54 +0100 Subject: [PATCH 2/2] fix typo --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index b75f2d8..8a40dc4 100644 --- a/README.md +++ b/README.md @@ -56,7 +56,7 @@ reporter.sendTelemetryErrorEvent('sampleErrorEvent', { 'stringProp': 'some strin - **Extension Version** `common.extversion` - The extension version - **Machine Identifier** `common.vscodemachineid` - A common machine identifier generated by VS Code - **Session Identifier** `common.vscodesessionid` - A session identifier generated by VS Code -- **Machine Identifier** `common.vscodecommithash` - A VS Code commit hash +- **VS Code Commit** `common.vscodecommithash` - A VS Code commit hash - **VS Code Version** `common.vscodeversion` - The version of VS Code running the extension - **OS** `common.os` - The OS running VS Code - **Platform Version** `common.platformversion` - The version of the OS/Platform