From e17e9ed2f1b7c66db567f0a4b20c549b562d62cc Mon Sep 17 00:00:00 2001 From: Logan Ramos Date: Wed, 13 Sep 2023 14:40:48 -0700 Subject: [PATCH] Less time for teardown (#186) --- src/browser/telemetryReporter.ts | 3 +-- src/common/1dsClientFactory.ts | 5 ++--- src/node/telemetryReporter.ts | 2 +- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/src/browser/telemetryReporter.ts b/src/browser/telemetryReporter.ts index 5915acc..211cc35 100644 --- a/src/browser/telemetryReporter.ts +++ b/src/browser/telemetryReporter.ts @@ -43,12 +43,11 @@ const webAppInsightsClientFactory = async (key: string, replacementOptions?: Rep appInsightsClient?.flush(false); }, dispose: async () => { - appInsightsClient?.flush(true); const unloadPromise = new Promise((resolve) => { appInsightsClient?.unload(true, () => { resolve(); appInsightsClient = undefined; - }); + }, 1000); } ); return unloadPromise; diff --git a/src/common/1dsClientFactory.ts b/src/common/1dsClientFactory.ts index 7a13020..fc38f48 100644 --- a/src/common/1dsClientFactory.ts +++ b/src/common/1dsClientFactory.ts @@ -103,17 +103,16 @@ export const oneDataSystemClientFactory = async (key: string, vscodeAPI: typeof }, flush: flushOneDS, dispose: async () => { - await flushOneDS(); const disposePromise = new Promise((resolve) => { if (!appInsightsCore) { resolve(); return; } - appInsightsCore.unload(true, () => { + appInsightsCore.unload(false, () => { resolve(); appInsightsCore = undefined; return; - }); + }, 1000); }); return disposePromise; } diff --git a/src/node/telemetryReporter.ts b/src/node/telemetryReporter.ts index f11ae5b..d406000 100644 --- a/src/node/telemetryReporter.ts +++ b/src/node/telemetryReporter.ts @@ -79,7 +79,7 @@ const appInsightsClientFactory = async (key: string, replacementOptions?: Replac } }, dispose: async () => { - appInsightsClient?.flush(); + appInsightsClient?.flush({ isAppCrashing: true }); appInsightsClient = undefined; } };