feat: pop-up on disabled extension

Author: FluoriteCafe-work

src/upgrade/upgradeManager.ts

@@ -11,7 +11,7 @@ import { Commands } from "../commands";
 import notificationManager from "./display/notificationManager";
 import { Settings } from "../settings";
 import assessmentManager from "./assessmentManager";
-import { checkOrInstallAppModExtension, checkOrPopupToInstallAppModExtension } from "./utility";
+import { checkOrInstallAppModExtensionForUpgrade, checkOrPopupToInstallAppModExtensionForModernization } from "./utility";
 
 const DEFAULT_UPGRADE_PROMPT = "Upgrade Java project dependency to latest version.";
 
@@ -26,14 +26,14 @@ class UpgradeManager {
 
         // Upgrade project
         context.subscriptions.push(instrumentOperationAsVsCodeCommand(Commands.JAVA_UPGRADE_WITH_COPILOT, async (promptText?: string) => {
-            await checkOrInstallAppModExtension(ExtensionName.APP_MODERNIZATION_UPGRADE_FOR_JAVA);
+            await checkOrInstallAppModExtensionForUpgrade(ExtensionName.APP_MODERNIZATION_UPGRADE_FOR_JAVA);
             const promptToUse = promptText ?? DEFAULT_UPGRADE_PROMPT;
             await commands.executeCommand(Commands.GOTO_AGENT_MODE, { prompt: promptToUse });
         }));
 
         // Show modernization view
         context.subscriptions.push(instrumentOperationAsVsCodeCommand(Commands.VIEW_MODERNIZE_JAVA_PROJECT, async () => {
-            await checkOrPopupToInstallAppModExtension(
+            await checkOrPopupToInstallAppModExtensionForModernization(
                 ExtensionName.APP_MODERNIZATION_FOR_JAVA,
                 `${ExtensionName.APP_MODERNIZATION_EXTENSION_NAME} extension is required to modernize Java projects. Would you like to install it and modernize this project?`,
                 "Install Extension and Modernize");

src/upgrade/utility.ts

@@ -74,7 +74,7 @@ export function normalizePath(path: string): string {
     return Uri.parse(path).toString();
 }
 
-async function checkOrPromptToEnableAppModExtension() {
+async function checkOrPromptToEnableAppModExtension(keyword: string) {
     if (extensions.getExtension(ExtensionName.APP_MODERNIZATION_FOR_JAVA)) {
         return;
     }
@@ -83,15 +83,16 @@ async function checkOrPromptToEnableAppModExtension() {
     await commands.executeCommand("workbench.extensions.search", ExtensionName.APP_MODERNIZATION_FOR_JAVA);
     const BTN_TEXT = "Show extension in sidebar";
     const choice2 = await window.showInformationMessage(
-        `${ExtensionName.APP_MODERNIZATION_EXTENSION_NAME} extension is required for the feature but seems disabled. Please enable it manually and try again.`,
+        `${ExtensionName.APP_MODERNIZATION_EXTENSION_NAME} extension is required to ${keyword} Java projects but it seems disabled. Please enable it manually and try again.`,
+        { modal: true },
         BTN_TEXT
     );
     if (choice2 === BTN_TEXT) {
         await commands.executeCommand("workbench.extensions.search", ExtensionName.APP_MODERNIZATION_FOR_JAVA);
     }
 }
 
-export async function checkOrPopupToInstallAppModExtension(
+export async function checkOrPopupToInstallAppModExtensionForModernization(
     extensionIdToCheck: string,
     notificationText: string,
     buttonText: string): Promise<void> {
@@ -106,15 +107,15 @@ export async function checkOrPopupToInstallAppModExtension(
         return;
     }
 
-    await checkOrPromptToEnableAppModExtension();
+    await checkOrPromptToEnableAppModExtension("modernize");
 }
 
-export async function checkOrInstallAppModExtension(
+export async function checkOrInstallAppModExtensionForUpgrade(
     extensionIdToCheck: string): Promise<void> {
     if (extensions.getExtension(extensionIdToCheck)) {
         return;
     }
 
     await commands.executeCommand("workbench.extensions.installExtension", ExtensionName.APP_MODERNIZATION_FOR_JAVA);
-    await checkOrPromptToEnableAppModExtension();
+    await checkOrPromptToEnableAppModExtension("upgrade");
 }