Skip to content
This repository has been archived by the owner on Apr 19, 2024. It is now read-only.

Allow createXlfFiles() respect existing <note> on xlf file. #20

Open
IlyaBiryukov opened this issue May 4, 2019 · 0 comments
Open

Allow createXlfFiles() respect existing <note> on xlf file. #20

IlyaBiryukov opened this issue May 4, 2019 · 0 comments
Milestone

Comments

@IlyaBiryukov
Copy link

We use createXlfFiles to generate ENU xlf file from 'package.nls.json', 'nls.metadata.header.json', and 'nls.metadata.json' files. Our loc team uses this ENU xlf file to produce translated xlfs.

The issue is that we have to have <note> elements in the trans units in our ENU xlf to pass instructions to the loc team, and createXlfFiles() just overwrites the ENU xlf, losing all the notes.

We had to work it around by getting the notes from the existing ENU xlf file first, and then applying them in our copy of createXlfFiles() as in this PR

I think this is a common scenario to be enabled in vscode-nls-dev

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants