All localized strings show up as 'Failed to load message bundle' in extension development host

[joyceerhl]

E.g. for RemoteHub:

[sadasant]

This is the case as well for VSIXs generated locally. Is there a workaround?

[joyceerhl]

@sadasant I worked around this in the extension development host by not using the nls loader in dev mode. You could modify your build scripts to not use the loader if an environment variable is set, perhaps?

[sadasant]

@joyceerhl that makes sense! thank you!

[TylerLeonhardt]

I'm thinking in the patcher we could include the original string so that that is used as a fallback instead of throwing. Probably somewhere in this beast of a code block:

vscode-nls-dev/src/lib.ts

Lines 565 to 599 in 545e01a

	localizeCalls.reduce((memo, localizeCall) => {
	const firstArg = localizeCall.arguments[0];
	const secondArg = localizeCall.arguments[1];
	let key: string | null = null;
	let message: string | null = null;
	let comment: string[] = [];
	let text: string | null = null;
	if (ts.isStringLiteralLike(firstArg)) {
	text = firstArg.getText();
	key = text.substr(1, text.length - 2);
	} else if (ts.isObjectLiteralExpression(firstArg)) {
	for (let i = 0; i < firstArg.properties.length; i++) {
	const property = firstArg.properties[i];
	if (ts.isPropertyAssignment(property)) {
	const name = property.name.getText();
	if (name === 'key') {
	const initializer = property.initializer;
	if (ts.isStringLiteralLike(initializer)) {
	text = initializer.getText();
	key = text.substr(1, text.length - 2);
	}
	} else if (name === 'comment') {
	const initializer = property.initializer;
	if (ts.isArrayLiteralExpression(initializer)) {
	initializer.elements.forEach(element => {
	if (ts.isStringLiteralLike(element)) {
	text = element.getText();
	comment.push(text.substr(1, text.length - 2));
	}
	});
	}
	}
	}
	}
	}

What do you think @dbaeumer?

[dbaeumer]

The drawback of this is that we might have strings double in memory. This would put all English strings into the source code and they would be ignored if a LP is used. I guess this is the reason why I didn't do this in the first place.