Don't import from node in extensions for URL and TextEncoder

Fixes #90162

Follow up on b1c5e2f

Author: mjbvz

extensions/git/src/fileSystemProvider.ts

@@ -9,7 +9,6 @@ import { fromGitUri, toGitUri } from './uri';
 import { Model, ModelChangeEvent, OriginalResourceChangeEvent } from './model';
 import { filterEvent, eventToPromise, isDescendant, pathEquals, EmptyDisposable } from './util';
 import { Repository } from './repository';
-import { TextEncoder } from 'util';
 
 interface CacheRow {
 	uri: Uri;

extensions/git/src/typings/refs.d.ts

@@ -4,4 +4,5 @@
  *--------------------------------------------------------------------------------------------*/
 
 /// <reference path='../../../../src/vs/vscode.d.ts'/>
-/// <reference path='../../../../src/vs/vscode.proposed.d.ts'/>
+/// <reference path='../../../../src/vs/vscode.proposed.d.ts'/>
+/// <reference path="../../../types/lib.textEncoder.d.ts" />

extensions/types/lib.textEncoder.d.ts

@@ -0,0 +1,11 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the MIT License. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+// Define TextEncoder + TextDecoder globals for both browser and node runtimes
+//
+// Proper fix: https://github.com/microsoft/TypeScript/issues/31535
+
+declare var TextDecoder: typeof import('util').TextDecoder;
+declare var TextEncoder: typeof import('util').TextEncoder;

extensions/types/lib.url.d.ts

@@ -0,0 +1,10 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the MIT License. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+// Define Url global for both browser and node runtimes
+//
+// Copied from https://github.com/DefinitelyTyped/DefinitelyTyped/issues/34960
+
+declare const URL: typeof import('url').URL;

extensions/vscode-api-tests/src/extension.ts

@@ -15,9 +15,6 @@
 import * as vscode from 'vscode';
 
 declare const window: unknown;
-declare const TextEncoder: any;
-declare const TextDecoder: any;
-declare const URL: any;
 
 const textEncoder = new TextEncoder();
 const SCHEME = 'memfs';

extensions/vscode-api-tests/src/typings/ref.d.ts

@@ -5,4 +5,6 @@
 
 /// <reference path="../../../../src/vs/vscode.d.ts" />
 /// <reference path="../../../../src/vs/vscode.proposed.d.ts" />
+/// <reference path="../../../types/lib.textEncoder.d.ts" />
+/// <reference path="../../../types/lib.url.d.ts" />
 /// <reference types='@types/node'/>