Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't rely on QuickInputService in EditorResolverService #173691

Open
TylerLeonhardt opened this issue Feb 7, 2023 · 0 comments · May be fixed by #175578
Open

Don't rely on QuickInputService in EditorResolverService #173691

TylerLeonhardt opened this issue Feb 7, 2023 · 0 comments · May be fixed by #175578
Assignees
@lramos15
Labels
debt Code quality issues workbench-editor-resolver Issues resolving the editor inputs

Comments

@TylerLeonhardt
Copy link
Member

TylerLeonhardt commented Feb 7, 2023 •
edited
Loading

I'm trying to allow validation messages in the quick pick to support links. Unfortunately, adding OpenerService to the QuickInputService has left me in a service dependency cycle:

Can we move things around so the resolver service doesn't depend on QuickInput?

Logan had the idea of moving the usage into the commands which makes sense to me.
@lramos15 lramos15 added debt Code quality issues workbench-editor-resolver Issues resolving the editor inputs labels Feb 7, 2023
@lramos15 lramos15 linked a pull request Feb 27, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lramos15 lramos15

Labels
debt Code quality issues workbench-editor-resolver Issues resolving the editor inputs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Explore moving quick input dependency microsoft/vscode
2 participants
@TylerLeonhardt @lramos15