Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let tab content provide custom icon name #200147

Closed
hbons opened this issue Dec 6, 2023 · 1 comment
Closed

Let tab content provide custom icon name #200147

hbons opened this issue Dec 6, 2023 · 1 comment
Assignees
@benibenj
Labels
ux User experience issues workbench-editors Managing of editor widgets in workbench window workbench-tabs VS Code editor tab issues

Comments

@hbons
Copy link
Member

hbons commented Dec 6, 2023

Right now tabs with non-file content like Settings/Extensions/PRs use the generic text file icon in the tab bar. It would improve ease of navigation if content that's not a file could provide their own icon name.

In this mockup the extensions, settings and git-pull-request are used:

image
@hbons hbons added the ux User experience issues label Dec 6, 2023
@hbons hbons added this to the On Deck milestone Dec 6, 2023
@bpasero
Copy link
Member

bpasero commented Dec 7, 2023

👍 , the implementation issue is #199965 from @benibenj

@bpasero bpasero added workbench-tabs VS Code editor tab issues workbench-editors Managing of editor widgets in workbench window labels Dec 7, 2023
@benibenj benibenj mentioned this issue Dec 8, 2023
Merged
@bpasero bpasero modified the milestones: On Deck, December / January 2024 Dec 11, 2023
@benibenj benibenj mentioned this issue Dec 15, 2023
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@benibenj benibenj

Labels
ux User experience issues workbench-editors Managing of editor widgets in workbench window workbench-tabs VS Code editor tab issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hbons @bpasero @benibenj