Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetBoundingClientRect zoom adjustments #233692

Open
34 tasks done
deepak1556 opened this issue Nov 12, 2024 · 1 comment · May be fixed by #234970
Open
34 tasks done

GetBoundingClientRect zoom adjustments #233692

deepak1556 opened this issue Nov 12, 2024 · 1 comment · May be fixed by #234970
Assignees
@deepak1556
Labels
debt Code quality issues engineering VS Code - Build / issue tracking / etc.
Milestone
Backlog

Comments

@deepak1556
Copy link
Collaborator

deepak1556 commented Nov 12, 2024 •
edited
Loading

With https://chromium-review.googlesource.com/c/chromium/src/+/5085708 which got enabled by default since Chromium 128 via https://chromium-review.googlesource.com/c/chromium/src/+/5693338, the rect values from getBoundingClientRect calls will be adjusted to the page zoom rather than css zoom values.

I have listed the callsites that need confirmation if they are prepared for this feature.
@deepak1556 deepak1556 self-assigned this Nov 12, 2024
@deepak1556 deepak1556 added this to the On Deck milestone Nov 12, 2024
@deepak1556
Copy link
Collaborator Author

After going through the listed callsites, the following changes need to be adjusted for the new behavior

85bf8af
a1b53fd

@deepak1556 deepak1556 added debt Code quality issues engineering VS Code - Build / issue tracking / etc. labels Dec 2, 2024
@deepak1556 deepak1556 linked a pull request Dec 2, 2024 that will close this issue
Draft
@kieferrm kieferrm mentioned this issue Jan 13, 2025
Closed
62 tasks
@deepak1556 deepak1556 modified the milestones: On Deck, February 2025 Jan 27, 2025
@kieferrm kieferrm mentioned this issue Feb 10, 2025
Open
57 tasks
@joaomoreno joaomoreno modified the milestones: February 2025, Backlog Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deepak1556 deepak1556

Labels
debt Code quality issues engineering VS Code - Build / issue tracking / etc.
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

fix: account for page zoom factor in getBoundingClientRect microsoft/vscode
2 participants
@joaomoreno @deepak1556