I am using your steps, but I cannot reproduce this. Do you have any other setting that could influence this?

Please diagnose the root cause of the issue by running the command F1 > Help: Troubleshoot Issue and following the instructions. Once you have done that, please update the issue with the results.

Happy Coding!

can confirm

@jrieken reload VSCode with the file open
more specifically; have that Snippet file the first Snippet file you've opened since reload

have "editor.suggest.insertMode" set to default "insert"

related #231224

"[snippets]" will need to be added to "configurationDefaults"

"[jsonl]" should also be added aswell

PR #235605

partial pr #235605

@RedCMD Sorry, I can still not produce. Please help by distilling exact reproducible step and do not jump to any conclusions yet

can confirm insiders.vscode.dev

thank you for your time

🤷

@aeschli Do you have a clue? This seems to be JSON-schema based completions related but I can't reproduce

type the double quotes first "|"

or place any character after your cursor

eg. bo|dy results in "body": "|"dy

1. make sure "editor.suggest.insertMode" is set to default "insert"
2. Create .code-snippets file with code

{
	"test": {
		""
	}
}

2. assign language snippets
3. place cursor at the "" position and attempt code completion of "body"
   
4. expect the correct number of valid double quotes
   

actual:
3 sets of double quotes """ are created 🐛

please do not skip any steps
and provide a video if it's not reproducing
thanks

I have updated the original steps, it's important to start with "|" before asking for suggestions

@aeschli I can see that JSON gives this completion text and no "overwrite after", which then leads to double quotes. Check insertText here

The problem is that for snippets, the default is 'insert' mode. For JSON it is 'replace' mode.

For this example:

"test": {
""
}

with the cursor between the "", the JSON language server produces the following suggestion:
replace: insertText: "body": "$1", range: [1, 0] - [1, 2]
insert: insertText: "body": "$1", range: [1, 0] - [1, 1]

The JSON server produces the correct results, it's just that users don't expect insert mode, they expect replace mode.

The problem is that for snippets, the default is 'insert' mode. For JSON it is 'replace' mode.

Which is incompatible with VS Code's default. Can't we get alignment here?

Which is incompatible with VS Code's default. Can't we get alignment here?

@jrieken #209534 (comment)

IMO using insert as default would mean for JSON to no longer return richer completions such as "value": "property" when completing inside "". The completion would have to be value only. The user would then move the cursor over the " and type : and then complete the value.
That would be quite a change in how JSON editing works and a loss of convenience to the user.
Same would apply to CSS and HTML which also have values as quoted strings
IMO insert is not good for languages with quoted strings given that we always auto close quotes.

IMO insert is not good for languages with quoted strings given that we always auto close quotes.

We added replace-ranges quite late to VS Code, how did JSON work the years before that?

og commits:
2017 "editor.quickSuggestions": dc31a48
2019 "editor.suggest.insertMode": 5f1b81b#diff-85bdebc30242f87ed2d5fde09e5db9b58126b1d5c8b14bd18164f250ac9a649bR101

Code completions started with insertText. Shortly after the range was added, allowing completions to have full control of what was replaced before and after the cursor as well. That's when JSON/CSS/HTML was mostly written. Only much later, the concepts of insert and replace mode was added and 'insert' was declared as the default. I already brought it up at the time that this didn't fit well with what we already had with JSON/CSS/HTML and going to a pure 'insert' mode would be a step back for the user experience in JSON/CSS/HTML

Only much later, the concepts of insert and replace mode was added and 'insert' was declared as the default.

But that's only a user default (because it matches what mostlanguages were doing at the time, and still do). It does not mean each language must implement insert and replace for all completions, you could have left everything as before.

In JSON, with a complex suggestion like "key": "value" only offer one variant, for a simple suggestion like value offer both, unbiased wrt the user's config.