Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The bottom border of Manage menu is cut #228659

Open
uynilo9 opened this issue Sep 15, 2024 · 4 comments · May be fixed by #235711
Open

The bottom border of Manage menu is cut #228659

uynilo9 opened this issue Sep 15, 2024 · 4 comments · May be fixed by #235711
Assignees
@benibenj
Labels
layout General VS Code workbench layout issues polish Cleanup and polish issue workbench-views Workbench view issues
Milestone
Backlog

Comments

@uynilo9
Copy link

uynilo9 commented Sep 15, 2024 •
edited
Loading

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.93.1
  • OS Version: Windows_NT x64 10.0.19045

Steps to Reproduce:

  1. Hide the Status bar
  2. Click the Manage button in the bottem left
  3. See the picture below

image

(Update: it's still remaining in version 1.93.1)
@vs-code-engineering VS Code Engineering
Copy link

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.93.1. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

@bhavyaus bhavyaus assigned benibenj and unassigned bhavyaus Sep 18, 2024
@benibenj
Copy link
Contributor

I'm not seeing to on my own windows machine.

  • Are you using a none default theme?
  • Does it only happen when the status bar is hidden?

@uynilo9
Copy link
Author

uynilo9 commented Sep 22, 2024

Can you provide your screenshot?

Yes, it only happens when the status bar is hidden.

In my case, even if I'd reloaded the vscode with disabling all extensions and the default theme, it still happened. See the picture below:

image

@benibenj benibenj added polish Cleanup and polish issue layout General VS Code workbench layout issues workbench-views Workbench view issues labels Sep 23, 2024
@benibenj benibenj changed the title The bottom border of popup menu is cut The bottom border of Manage menu is cut Dec 10, 2024
@benibenj benibenj added this to the Backlog milestone Dec 10, 2024
benibenj added a commit that referenced this issue Dec 10, 2024
@benibenj
fixes #228659
6cb325b
@benibenj benibenj linked a pull request Dec 10, 2024 that will close this issue
Draft
@benibenj
Copy link
Contributor

Menus show a border which is actually an outline of 1px that is probably not considered in the layout computation:

vscode/src/vs/base/browser/ui/contextview/contextview.ts

Line 262 in 05fd130

private doLayout(): void {

vscode/src/vs/base/browser/ui/menu/menu.ts

Line 319 in 05fd130

private styleScrollElement(scrollElement: HTMLElement, style: IMenuStyles): void {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benibenj benibenj

Labels
layout General VS Code workbench layout issues polish Cleanup and polish issue workbench-views Workbench view issues
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Fix bottom border of Manage menu microsoft/vscode
3 participants
@bhavyaus @benibenj @uynilo9