Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better token support in standalone themes for monaco #236440

Closed
Pistonight opened this issue Dec 18, 2024 · 3 comments · May be fixed by #236441
Closed

Better token support in standalone themes for monaco #236440

Pistonight opened this issue Dec 18, 2024 · 3 comments · May be fixed by #236441
Assignees
@hediet
Labels
feature-request Request for new features or functionality monaco-editor
Milestone
Backlog Candidates

Comments

@Pistonight
Copy link

The standalone themes in src/vs/editor/standalone/common/themes.ts are very outdated and do not support modern language features such as functions. This makes it impossible to have good syntax highlighting out-of-the-box for some languages like TypeScript for downstream projects. See microsoft/monaco-editor#2872

It would be nice to update these themes to include modern tokens from VS Code Modern themes (dark_modern and light_modern)
@Pistonight Pistonight mentioned this issue Dec 18, 2024
Open
@aeschli aeschli assigned hediet and unassigned aeschli Dec 18, 2024
@aeschli aeschli added feature-request Request for new features or functionality monaco-editor labels Dec 18, 2024
@vs-code-engineering vs-code-engineering bot added this to the Backlog Candidates milestone Dec 18, 2024
@vs-code-engineering VS Code Engineering
Copy link

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vs-code-engineering VS Code Engineering
Copy link

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vs-code-engineering VS Code Engineering
Copy link

🙁 In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vs-code-engineering vs-code-engineering bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hediet hediet

Labels
feature-request Request for new features or functionality monaco-editor
Projects
None yet
Milestone
Backlog Candidates
Development

Successfully merging a pull request may close this issue.

Support more tokens in standalone themes Pistonight/vscode
3 participants
@hediet @aeschli @Pistonight