Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

markdown.copyFiles.destination doesn't apply to .mov files? #239016

Open
roblourens opened this issue Jan 28, 2025 · 3 comments · May be fixed by #239046
Open

markdown.copyFiles.destination doesn't apply to .mov files? #239016

roblourens opened this issue Jan 28, 2025 · 3 comments · May be fixed by #239046
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug markdown Markdown support issues
Milestone
February 2025

Comments

@roblourens
Copy link
Member

I pasted a png and a mov file from my Desktop. I have

"markdown.copyFiles.destination": {
    "**/*": "${fileName}.${unixTime}.md"
  },

It's confusing which files this applies to, the setting doesn't say specifically. The doc says "images" mostly but also "media files" in one place. https://code.visualstudio.com/docs/languages/markdown#_inserting-images-and-links-to-files. And I just expected that if it works on images, it would work on videos?

Image
@mjbvz
Copy link
Collaborator

mjbvz commented Jan 28, 2025

Yes needs a doc update and small fix. It should work for any media file (image, video, audio) but importantly we previously didn't consider .mov as media

@mjbvz mjbvz added this to the January 2025 milestone Jan 28, 2025
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Jan 28, 2025
@mjbvz mjbvz modified the milestones: January 2025, February 2025 Jan 28, 2025
@mjbvz
Copy link
Collaborator

mjbvz commented Jan 28, 2025

Pushing to feb since not a regression and I want to try a more complete fix

@mjbvz mjbvz added the markdown Markdown support issues label Jan 28, 2025
mjbvz added a commit to mjbvz/vscode that referenced this issue Jan 28, 2025
@mjbvz
Support more image/video/audio types for markdown copy into files
f9213d7 
Fixes microsoft#239016
@mjbvz mjbvz linked a pull request Jan 28, 2025 that will close this issue
Draft
@Jorge-Martin777
Copy link

"markdown.copyFiles.destination": {
"**/*": "${fileName}.${unixTime}.md"
`},```

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug markdown Markdown support issues
Projects
None yet
Milestone
February 2025
Development

Successfully merging a pull request may close this issue.

Support more image/video/audio types for markdown copy into files mjbvz/vscode
3 participants
@roblourens @mjbvz @Jorge-Martin777