Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alert when code action fails #243119

Open
justschen opened this issue Mar 10, 2025 · 0 comments
Open

alert when code action fails #243119

justschen opened this issue Mar 10, 2025 · 0 comments
Assignees
@justschen
Labels
editor-code-actions Editor inplace actions (Ctrl + .)

Comments

@justschen
Copy link
Contributor 

          Yeah I'm inclined to say that we should surface this error to the user so they can report it. Ia actually thought that's what we were doing on the VS Code side by calling `onUnexpectedExternalError`:

vscode/src/vs/editor/contrib/codeAction/common/types.ts

Line 185 in cb807ec

onUnexpectedExternalError(err);

But it turns out we end up silently catching the error

@justschen Want to try changing our code to alert when resolve fails?

Originally posted by @mjbvz in microsoft/language-server-protocol#2112 (comment)
@justschen justschen self-assigned this Mar 10, 2025
@justschen justschen transferred this issue from microsoft/language-server-protocol Mar 10, 2025
@justschen justschen added the editor-code-actions Editor inplace actions (Ctrl + .) label Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justschen justschen

Labels
editor-code-actions Editor inplace actions (Ctrl + .)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@justschen