fix: address PR #92 coverage command review comments

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: spboyer

README.md

@@ -281,7 +281,7 @@ Generate a skill-to-eval coverage grid showing which skills are fully covered, p
 | Flag | Short | Description |
 |------|-------|-------------|
 | `--format <fmt>` | `-f` | Output format: `text`, `markdown`, or `json` (default: `text`) |
-| `--discover <dir>` | | Additional directory to scan for skills/evals (repeatable) |
+| `--path <dir>` | | Additional directory to scan for skills/evals (repeatable) |
 
 ### `waza cache clear`
 

cmd/waza/cmd_coverage.go

@@ -204,7 +204,7 @@ func discoverSkillFiles(root string, discoverPaths []string) (map[string]string,
 		}
 		err := filepath.WalkDir(sr, func(path string, d fs.DirEntry, err error) error {
 			if err != nil {
-				return nil
+				return fmt.Errorf("error walking %s: %w", path, err)
 			}
 			if d.IsDir() {
 				name := d.Name()
@@ -216,7 +216,10 @@ func discoverSkillFiles(root string, discoverPaths []string) (map[string]string,
 			if d.Name() != "SKILL.md" {
 				return nil
 			}
-			absPath, _ := filepath.Abs(path)
+			absPath, absErr := filepath.Abs(path)
+			if absErr != nil {
+				absPath = filepath.Clean(path)
+			}
 			if _, ok := seenPaths[absPath]; ok {
 				return nil
 			}
@@ -252,7 +255,7 @@ func discoverEvalFiles(root string, skillPaths map[string]string, discoverPaths
 		}
 		if err := filepath.WalkDir(evalRoot, func(path string, d fs.DirEntry, err error) error {
 			if err != nil {
-				return nil
+				return fmt.Errorf("error walking %s: %w", path, err)
 			}
 			if d.IsDir() {
 				name := d.Name()
@@ -262,7 +265,10 @@ func discoverEvalFiles(root string, skillPaths map[string]string, discoverPaths
 				return nil
 			}
 			if d.Name() == "eval.yaml" || d.Name() == "eval.yml" {
-				absPath, _ := filepath.Abs(path)
+				absPath, absErr := filepath.Abs(path)
+				if absErr != nil {
+					absPath = filepath.Clean(path)
+				}
 				candidates[absPath] = struct{}{}
 			}
 			return nil
@@ -280,7 +286,10 @@ func discoverEvalFiles(root string, skillPaths map[string]string, discoverPaths
 		} {
 			p := filepath.Join(skillDir, rel)
 			if isFile(p) {
-				absPath, _ := filepath.Abs(p)
+				absPath, absErr := filepath.Abs(p)
+				if absErr != nil {
+					absPath = filepath.Clean(p)
+				}
 				candidates[absPath] = struct{}{}
 			}
 		}

cmd/waza/cmd_coverage_test.go

@@ -2,6 +2,7 @@ package main
 
 import (
 	"bytes"
+	"encoding/json"
 	"os"
 	"path/filepath"
 	"testing"
@@ -123,6 +124,41 @@ func TestRenderCoverageMarkdown(t *testing.T) {
 	assert.Contains(t, out, "| beta | 2 | file, prompt | ✅ Full |")
 }
 
+func TestRenderCoverageJSON(t *testing.T) {
+	report := &coverageReport{
+		TotalSkills: 1,
+		Covered:     1,
+		Partial:     0,
+		Uncovered:   0,
+		CoveragePct: 100,
+		Skills: []coverageSkillRow{
+			{Skill: "alpha", Tasks: 2, Graders: []string{"file", "prompt"}, Coverage: "✅ Full"},
+		},
+	}
+
+	var buf bytes.Buffer
+	require.NoError(t, renderCoverageJSON(&buf, report))
+
+	var decoded map[string]any
+	require.NoError(t, json.Unmarshal(buf.Bytes(), &decoded))
+	assert.Equal(t, float64(1), decoded["total_skills"])
+	assert.Contains(t, buf.String(), "\n  \"total_skills\"")
+}
+
+func TestCoverageCommand_UnsupportedFormat(t *testing.T) {
+	root := t.TempDir()
+	writeSkill(t, root, filepath.Join("skills", "alpha"), "alpha")
+
+	cmd := newCoverageCommand()
+	cmd.SetOut(new(bytes.Buffer))
+	cmd.SetErr(new(bytes.Buffer))
+	cmd.SetArgs([]string{root, "--format", "xml"})
+
+	err := cmd.Execute()
+	require.Error(t, err)
+	assert.Contains(t, err.Error(), `unsupported format "xml"`)
+}
+
 func TestRootCommand_HasCoverageSubcommand(t *testing.T) {
 	root := newRootCommand()
 	found := false

site/src/content/docs/reference/cli.mdx

@@ -274,7 +274,7 @@ waza coverage [root]
 
 | Flag | Description |
 |------|-------------|
-| `--format` | Output format: `text` (default), `markdown`, `json` |
+| `-f, --format` | Output format: `text` (default), `markdown`, `json` |
 | `--path` | Additional directories to scan for skills/evals (repeatable) |
 
 ### Examples