Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Package: GnuWin32.Flex #212692

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

New Package: GnuWin32.Flex #212692

wants to merge 4 commits into from
+44 −0

Conversation

soroshsabz
Copy link
Contributor

@soroshsabz soroshsabz commented Jan 15, 2025 •
edited
Loading

ITNOA

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.9 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

Dragon1573
Dragon1573 reviewed Jan 16, 2025
View reviewed changes
Copy link
Contributor

@Dragon1573 Dragon1573 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Manual validated.

--> Installing WinGet
--> Disabling safety warning when running installers
Tip: you can type 'Update-EnvironmentVariables' to update your environment variables, such as after installing a new software.

--> Configuring Winget
已启用管理员设置 'LocalManifestFiles'。
已启用管理员设置 'LocalArchiveMalwareScanOverride'。

--> Installing the Manifest 2.5.4

已找到 GnuWin32: Flex [GnuWin32.Flex] 版本 2.5.4
此应用程序由其所有者授权给你。
Microsoft 对第三方程序包概不负责，也不向第三方程序包授予任何许可证。
正在下载 https://kumisystems.dl.sourceforge.net/project/gnuwin32/flex/2.5.4a-1/flex-2.5.4a-1.exe
  ██████████████████████████████  1.16 MB / 1.16 MB
已成功验证安装程序哈希
正在启动程序包安装...
已成功安装

--> Refreshing environment variables

--> Comparing ARP Entries

DisplayName                   DisplayVersion Publisher ProductCode     Scope
-----------                   -------------- --------- -----------     -----
GnuWin32: Flex version 2.5.4a 2.5.4a         GnuWin32  Flex-2.5.4a_is1 Machine

⚠️ But it seems both flex.exe and flex++.exe is not available from Startup Panel or PowerShell Console after installation.

@soroshsabz
Copy link
Contributor Author

@Dragon1573 Thanks for reviewing

inno original installation does not add bin path to windows env path, so after installation flex does not work, as same as bison and other GnuWin32 packages in winget

@soroshsabz
Copy link
Contributor Author

@Dragon1573 if you have any idea to change easily installation process, and add bin in path, I welcome to learn it :)

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@Dragon1573
Copy link
Contributor

If you have any idea to change easily installation process, and add bin in path, I welcome to learn it :)

Nope. For any other install technology than ZIP archives, winget.exe will only pass pre-defined switches to the install wizard. Registry modifications, envrionment variables modification and shortcuts creation will only been done by the install wizard itself.

If they peovides pre-built binary archives, you might able to try it with adding ArchiveBinariesDependOnPath: true.

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@soroshsabz
Copy link
Contributor Author

soroshsabz commented Jan 16, 2025 •
edited
Loading

PATH problem is related to microsoft/winget-cli#549 and I think we need to wait to add that features to winget

@Dragon1573 so any blockers exist for preventing merge this PR?

thanks

Dragon1573
Dragon1573 approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@Dragon1573 Dragon1573 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏼

Important

Since I'm NOT one of the moderators, My approval WILL NOT trigger the auto-merge.

Please be patient for their official approval. ❤️

@stephengillie
Copy link
Collaborator

@wingetbot run

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot wingetbot added the Manifest-Validation-Error Manifest validation failed label Jan 16, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Jan 16, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot removed Manifest-Validation-Error Manifest validation failed Needs-Author-Feedback This needs a response from the author. labels Jan 17, 2025
@soroshsabz
Copy link
Contributor Author

@wingetbot run

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Unapproved-URL labels Jan 17, 2025
@stephengillie
Copy link
Collaborator

@wingetbot run

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@stephengillie stephengillie removed the Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. label Jan 17, 2025
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Unapproved-URL labels Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dragon1573 Dragon1573 Dragon1573 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@stephengillie stephengillie

Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. New-Package Validation-Unapproved-URL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Package Request]: Flex
4 participants
@soroshsabz @wingetbot @Dragon1573 @stephengillie