fix comments

Author: ssss141414

scripts/e2e_eval/datasets/build_ai4privacy.py

@@ -59,11 +59,16 @@ def build_dataset(output_dir: Path) -> None:
     print("Done.")
 
 
+_DEFAULT_CACHE_DIR = Path.home() / ".cache" / "winml" / "eval_datasets" / "build_ai4privacy"
+
+
 def main() -> None:
     parser = argparse.ArgumentParser(description="Build ai4privacy PII dataset")
-    parser.add_argument("--output", type=Path, required=True, help="Output directory")
+    parser.add_argument("--output", type=Path, default=None, help="Output directory (default: ~/.cache/winml/eval_datasets/build_ai4privacy)")
     args = parser.parse_args()
-    build_dataset(args.output)
+    output_dir = args.output or _DEFAULT_CACHE_DIR
+    build_dataset(output_dir)
+    print(output_dir)
 
 
 if __name__ == "__main__":

scripts/e2e_eval/datasets/build_fairface.py

@@ -95,11 +95,16 @@ def build_dataset(output_dir: Path) -> None:
     print("Done.")
 
 
+_DEFAULT_CACHE_DIR = Path.home() / ".cache" / "winml" / "eval_datasets" / "build_fairface"
+
+
 def main() -> None:
     parser = argparse.ArgumentParser(description="Build fairface validation dataset")
-    parser.add_argument("--output", type=Path, required=True, help="Output directory")
+    parser.add_argument("--output", type=Path, default=None, help="Output directory (default: ~/.cache/winml/eval_datasets/build_fairface)")
     args = parser.parse_args()
-    build_dataset(args.output)
+    output_dir = args.output or _DEFAULT_CACHE_DIR
+    build_dataset(output_dir)
+    print(output_dir)
 
 
 if __name__ == "__main__":

scripts/e2e_eval/datasets/build_indonlu_posp.py

@@ -44,11 +44,16 @@ def build_dataset(output_dir: Path) -> None:
     print("Done.")
 
 
+_DEFAULT_CACHE_DIR = Path.home() / ".cache" / "winml" / "eval_datasets" / "build_indonlu_posp"
+
+
 def main() -> None:
     parser = argparse.ArgumentParser(description="Build indonlu posp dataset")
-    parser.add_argument("--output", type=Path, required=True, help="Output directory")
+    parser.add_argument("--output", type=Path, default=None, help="Output directory (default: ~/.cache/winml/eval_datasets/build_indonlu_posp)")
     args = parser.parse_args()
-    build_dataset(args.output)
+    output_dir = args.output or _DEFAULT_CACHE_DIR
+    build_dataset(output_dir)
+    print(output_dir)
 
 
 if __name__ == "__main__":

scripts/e2e_eval/datasets/build_pubtables1m_detection.py

@@ -198,11 +198,16 @@ def build_dataset(output_dir: Path) -> None:
     print("Done.")
 
 
+_DEFAULT_CACHE_DIR = Path.home() / ".cache" / "winml" / "eval_datasets" / "build_pubtables1m_detection"
+
+
 def main() -> None:
     parser = argparse.ArgumentParser(description="Build PubTables-1M detection dataset")
-    parser.add_argument("--output", type=Path, required=True, help="Output directory")
+    parser.add_argument("--output", type=Path, default=None, help="Output directory (default: ~/.cache/winml/eval_datasets/build_pubtables1m_detection)")
     args = parser.parse_args()
-    build_dataset(args.output)
+    output_dir = args.output or _DEFAULT_CACHE_DIR
+    build_dataset(output_dir)
+    print(output_dir)
 
 
 if __name__ == "__main__":

scripts/e2e_eval/datasets/build_pubtables1m_structure.py

@@ -206,11 +206,16 @@ def build_dataset(output_dir: Path) -> None:
     print("Done.")
 
 
+_DEFAULT_CACHE_DIR = Path.home() / ".cache" / "winml" / "eval_datasets" / "build_pubtables1m_structure"
+
+
 def main() -> None:
     parser = argparse.ArgumentParser(description="Build PubTables-1M structure recognition dataset")
-    parser.add_argument("--output", type=Path, required=True, help="Output directory")
+    parser.add_argument("--output", type=Path, default=None, help="Output directory (default: ~/.cache/winml/eval_datasets/build_pubtables1m_structure)")
     args = parser.parse_args()
-    build_dataset(args.output)
+    output_dir = args.output or _DEFAULT_CACHE_DIR
+    build_dataset(output_dir)
+    print(output_dir)
 
 
 if __name__ == "__main__":

src/winml/modelkit/commands/eval.py

@@ -226,9 +226,8 @@ def eval(
             raise click.ClickException(
                 f"Dataset script failed: {result.stderr.strip()[-200:]}"
             )
-        # Use script output (stdout) as dataset path if not already set
         script_output = result.stdout.strip()
-        if script_output and not cli_utils.is_cli_provided(ctx, "dataset_path"):
+        if script_output:
             dataset_path = script_output
 
     if show_schema:

src/winml/modelkit/config/build.py

@@ -50,6 +50,7 @@
 from typing import TYPE_CHECKING, Any, overload
 
 from ..compiler.configs import WinMLCompileConfig
+from ..eval.config import WinMLEvaluationConfig
 from ..export.config import (
     InputTensorSpec,
     OutputTensorSpec,
@@ -58,7 +59,6 @@
 )
 from ..loader.config import WinMLLoaderConfig, resolve_loader_config
 from ..optim.config import WinMLOptimizationConfig
-from ..eval.config import WinMLEvaluationConfig
 from ..quant.config import WinMLQuantizationConfig
 from ..utils.config_utils import merge_config
 
@@ -884,6 +884,7 @@ def _merge_export_config(
         dynamic_axes=(
             override.dynamic_axes if override.dynamic_axes is not None else base.dynamic_axes
         ),
+        dynamo=override.dynamo if override.dynamo else base.dynamo,
     )