Unable to patch TrustFrameworkPolicy

[greiggs]

Describe the bug

I am trying to write an automated system for adding and patching TrustFramework Policies using Microsoft.Identity.Web.GraphServiceClientBeta version 3.0.1 which is using Microsoft.Graph.Beta 5.78.0-preview.

I have successfully added a policy from the code provided by: Github msgraph-beta-sdk-dotnet issue 734 but I am unable to patch as it throws the following error:

No HTTP resource was found that matches the request URI 'https://cpim.windows.net/graph/trustFramework/policies('B2C_1A_TEST_01')'.","messageDetail":"No action was found on the controller 'trustframework' that matches the request.

Expected behavior

To patch a B2C Policy using the SDK. From looking at the api it indicates it should be a Put and not a Patch but there is no appropriate RequestInformation method on the graphServiceClient.TrustFramework.Policies[policyId] object.

How to reproduce

Run the following code:

Where:

• data: is a BinaryData object of the xml policy file.
• graphServiceClient: is a Beta.GraphServiceClient.
• policyId: is 'B2C_1A_TEST_01'

TrustFrameworkPolicyCollectionResponse? response = await graphServiceClient.TrustFramework.Policies.GetAsync();

TrustFrameworkPolicy? existingPolicy = response?.Value?.Where(x => x.Id == policyId).FirstOrDefault();

if (existingPolicy != null) {
  RequestInformation requestInformation = graphServiceClient.TrustFramework.Policies[policyId].ToPatchRequestInformation(existingPolicy);
  
  requestInformation.SetStreamContent(data.ToStream(), "application/xml");
  requestInformation.Headers.Add("Content-Type", "application/xml");
  
  Dictionary<string, ParsableFactory<IParsable>> errorMapping = new()
  {
      {"4XX", ODataError.CreateFromDiscriminatorValue},
      {"5XX", ODataError.CreateFromDiscriminatorValue},
  };
}

await graphServiceClient.RequestAdapter.SendNoContentAsync(requestInformation, errorMapping, cancellationToken);

SDK Version

5.78.0-preview

Latest version known to work for scenario above?

No response

Known Workarounds

No response

Debug output

Click to expand log

```

</details>


### Configuration

_No response_

### Other information

_No response_

[andrueastman]

Thanks for raising this @greiggs

Does this work if you do this instead when creating the request information object? According to the docs the right way to update is using a PUT at the /$value endpoint.

            RequestInformation requestInformation = graphServiceClient.TrustFramework.Policies["policyId"].Content.ToPutRequestInformation(data.ToStream());
            requestInformation.Headers.Add("Content-Type", "application/xml"); // metadata sets the content type as octet-stream

[greiggs]

@andrueastman Yes this worked thank you.

Can I ask if the approach (below) I am using to add is the correct way to do this or is there a simpler way as this seems overly complex? Also is there any documentation in how to use the SDK as I have had trouble trying to convert what the API requires into how the SDK works?

RequestInformation requestInformation = graphServiceClient.TrustFramework.Policies.ToPostRequestInformation(new() { Id = policyId, });

requestInformation.SetStreamContent(data.ToStream(), "application/xml");
requestInformation.Headers.Add("Content-Type", "application/xml");

Dictionary<string, ParsableFactory<IParsable>> errorMapping = new()
{
    {"4XX", ODataError.CreateFromDiscriminatorValue},
    {"5XX", ODataError.CreateFromDiscriminatorValue},
};

await graphServiceClient.RequestAdapter.SendNoContentAsync(requestInformation, errorMapping, cancellationToken);

[microsoft-github-policy-service]

No description provided.

[andrueastman]

Thanks for confirming this @greiggs

The Graph documentation typically should have examples on how to make calls using the SDK. See example at

https://learn.microsoft.com/en-us/graph/api/trustframeworkkeyset-get?view=graph-rest-beta&tabs=csharp

However, this API seems to be an edge case as the API metadata that is provided by the API team that is used to generate the SDK is incorrect. Specifically, it does not describe that the endpoint expects xml this makes the generation assume that the api expects json which would have a call the simply looks like this.

var result = await graphServiceClient.TrustFramework.Policies["policyId"].Content.PutAsync(data.ToStream());

To fully resolve this we probably need to

• Have the API metadata updated to reflect that the endpoint expect application/xml content
• Setup a default serializer for xml in the sdk so that the above sample would send xml with the sample above(created Add a default application/xml serialization library microsoft/kiota-dotnet#342)

Hope this helps make things clearer.