File tree 1 file changed +11
-1
lines changed
1 file changed +11
-1
lines changed Original file line number Diff line number Diff line change 1
1
2
2
### Graph JS Deliverables:
3
3
4
- Note: Package names yet to be decided
4
+ Note: Package names yet to be decided. The names are just examples and ` service ` and ` core ` prefix in the package names are for clarity purposes.
5
5
6
6
1 . ` microsoftgraph/microsoft-graph-javascript-service ` :
7
7
@@ -25,6 +25,15 @@ Note: Package names yet to be decided
25
25
26
26
As mentioned in PR: #558
27
27
28
+ Also, tasks constructors such as ` PageIterator ` and ` LargeFileUpload ` tasks should accept both ` GraphServiceClient ` and ` GraphCoreClient `
29
+
30
+ ```
31
+ // both should work
32
+ const pageIterator = PageIterator(GraphServiceClient, options);
33
+ or
34
+ const pageIterator = PageIterator(GraphCoreClient, options);
35
+ ```
36
+
28
37
Goals:
29
38
30
39
- A Graph JS SDK user should not be required to create separate client instances for Graph Service library or the Graph Core library.
@@ -45,6 +54,7 @@ class GraphServiceClient extends GraphCoreClient {
45
54
super.api();
46
55
}
47
56
}
57
+
48
58
```
49
59
50
60
- To acheive the above design we will need to customize the auto-generated ` GraphServiceClient ` .
You can’t perform that action at this time.
0 commit comments