Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typing of segments is incorrect #115

Closed
furedal opened this issue Jan 25, 2024 · 0 comments · Fixed by #117
Closed

Typing of segments is incorrect #115

furedal opened this issue Jan 25, 2024 · 0 comments · Fixed by #117

Comments

@furedal
Copy link

furedal commented Jan 25, 2024

https://github.com/mifi/react-lottie-player/blame/f3d8209593ba7bb9899039debad7c2a0389022a7/src/propTypes.js#L16

Just a small issue that throws a warning in the browser-logs.

right now it looks like that is only accepting: number[] + boolean while it should probably be number[] + `number[][]´
mifi added a commit that referenced this issue Jan 26, 2024
@mifi
fix segment prop type
ede357e 
fixes #115
@mifi mifi mentioned this issue Jan 26, 2024
Merged
@mifi mifi closed this as completed in #117 Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix segment prop type mifi/react-lottie-player
1 participant
@furedal