Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe version checking #89

Open
jmontleon opened this issue Nov 11, 2021 · 0 comments
Open

Safe version checking #89

jmontleon opened this issue Nov 11, 2021 · 0 comments

Comments

@jmontleon
Copy link
Contributor

There are at least a couple places we need to know the version of the openshift cluster in order to do things "the right way" (such as create an SCC and use a rolebinding and role to give a user a privilege, vs. a role/rolebinding that grants the use verb on an existing SCC).

The checks right now are basic, mostly looking at the kubernetes minor version, similar to what we've done in migration-controller, but perhaps there is a better way.

Also, some history, back around the QCI days we were using an OpenShift version API, but that was removed around somewhere around 3.10 and we could no longer rely on it, which is how we got here with crane-lib/mig-controller.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant