-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DropBlock1D #30
Comments
Would this be a right implementation?
|
looks fine to me. you can make a PR with that code and add a few unit tests (check the current ones). I'll happily review it for you. |
@miguelvr Thanks for your response. I now checked many of the existing unit tests. Also, using it already in two projects where in both it contributed. I am not very familiar with pull requests, etc. Therefore, please feel free to use the above block within the project if you would like including it. |
Can you please also include DropBlock1D implementation to use it for time-series? Thank you very much.
The text was updated successfully, but these errors were encountered: