Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference links parsing breaks [] text #91

Open
nonproto opened this issue Nov 30, 2023 · 2 comments
Open

Reference links parsing breaks [] text #91

nonproto opened this issue Nov 30, 2023 · 2 comments
Assignees

Comments

@nonproto
Copy link
Contributor

Currently if I have a markdown text with double [] such as

[This should work][This is not a link] this is just text 

Yada yadada
The end

The library assumes it's a reference link when parsing causing the output to be wrong and it becomes a clickable link to nothing.

@mikepenz
Copy link
Owner

mikepenz commented Dec 1, 2023

Screenshot 2023-12-01 at 11 04 50

Not certain if that's something which may be handled wrong (or is supposed to be that way (?)) from the underlying markdown parsing library

https://github.com/JetBrains/markdown

@mikepenz mikepenz self-assigned this Dec 1, 2023
@nonproto
Copy link
Contributor Author

nonproto commented Dec 1, 2023

Yea I saw it was also getting tagged wrong(?). I don't know if other parsers like GitHub tag it then ignore it when there is no reference. Or what exactly.

I assumed the parsing was correct, and as attempted to check destination null and link label was not null. Then checking if the linkreferencehandler store had a valid entry however that isn't filled in until after the parsing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants