Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS companion crashes if ListView SelectionIndex set to be too large #3153

Open
1 of 8 tasks
ewpatton opened this issue Mar 22, 2024 · 0 comments · Fixed by #3154
Open
1 of 8 tasks

iOS companion crashes if ListView SelectionIndex set to be too large #3153

ewpatton opened this issue Mar 22, 2024 · 0 comments · Fixed by #3154
Labels
affects: ucr bug ios issue: pending component release

Comments

@ewpatton
Copy link
Member

Describe the bug

From the forum: Specifying an out of bounds index in SelectionIndex can cause the iOS app to crash. It also appears as though the indexing is incorrect and assumes 0-index whereas App Inventor is 1-indexed.

Affects

  • Designer
  • Blocks editor
  • Projects Explorer
  • Companion
  • Compiled apps
  • Buildserver
  • Debugging
  • Other... (please describe)

Expected behavior

The app should not crash and the ListView should handle 1-based indexing.

Steps to reproduce

The forum post has details.
patryk84a added a commit to patryk84a/appinventor-sources that referenced this issue Mar 23, 2024
@patryk84a
ListView.swift mit-cml#3153
4d0dd80
patryk84a added a commit to patryk84a/appinventor-sources that referenced this issue Mar 23, 2024
@patryk84a
Merge pull request #4 from patryk84a/patryk84a-patch-#3153
b5ba642 
Fix for ListView.swift, issue  mit-cml#3153
@ewpatton ewpatton linked a pull request Apr 5, 2024 that will close this issue
Fix for ListView.swift, issue #3153 #3154
Merged
ewpatton pushed a commit that referenced this issue Apr 5, 2024
@patryk84a
Fix for ListView.swift issue #3153 (#3154)
8c66c50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects: ucr bug ios issue: pending component release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for ListView.swift, issue #3153 patryk84a/appinventor-sources
1 participant
@ewpatton