Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use scheme-specific link in Companion Information dialog #3190

Closed
1 of 8 tasks
ewpatton opened this issue Jun 27, 2024 · 0 comments · Fixed by #3253
Closed
1 of 8 tasks

Use scheme-specific link in Companion Information dialog #3190

ewpatton opened this issue Jun 27, 2024 · 0 comments · Fixed by #3253

Comments

@ewpatton
Copy link
Member

Describe the bug

The Companion Information dialog on ai2 uses an HTTP link for the companion download, even if the page itself is served over HTTPS. In particular, this is problematic because Chrome will not allow the user to download a file using an HTTP link when the host page is served over HTTPS. We should have the link's scheme reflect the page scheme.

Affects

  • Designer
  • Blocks editor
  • Projects Explorer
  • Companion
  • Compiled apps
  • Buildserver
  • Debugging
  • Other... (please describe)

Expected behavior

Clicking the link should trigger the download.

Steps to reproduce

  1. Open ai2 in Chrome
  2. Go to Help > Companion Information
  3. Click on the link for the companion app, it will not trigger a download
  4. If you edit the href in the dev tools to be HTTPS, the download link will work
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants