Skip to content

Commit 1082ec3

Browse files
committed
working through test fixes
1 parent 778344e commit 1082ec3

File tree

4 files changed

+24
-10
lines changed

4 files changed

+24
-10
lines changed

frontends/api/src/mitxonline/hooks/courses/queries.ts

Lines changed: 12 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,13 +26,20 @@ const coursesQueries = {
2626
coursesListInfinite: (opts?: CoursesApiApiV2CoursesListRequest) =>
2727
infiniteQueryOptions({
2828
queryKey: coursesKeys.coursesList(opts),
29-
queryFn:
30-
async ({ pageParam = 1 }): Promise<PaginatedCourseWithCourseRunsSerializerV2List> => {
31-
return coursesApi.apiV2CoursesList({ ...opts, page: pageParam }).then((res) => res.data)
32-
},
29+
queryFn: async ({
30+
pageParam = 1,
31+
}): Promise<PaginatedCourseWithCourseRunsSerializerV2List> => {
32+
return coursesApi
33+
.apiV2CoursesList({ ...opts, page: pageParam })
34+
.then((res) => res.data)
35+
},
3336
initialPageParam: 1,
3437
getNextPageParam: (lastPage, allPages, pageParam): number | null => {
35-
return lastPage && lastPage.next ? (pageParam ? pageParam + 1 : null) : null
38+
return lastPage && lastPage.next
39+
? pageParam
40+
? pageParam + 1
41+
: null
42+
: null
3643
},
3744
}),
3845
}

frontends/main/src/app-pages/DashboardPage/CoursewareDisplay/test-utils.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -154,13 +154,13 @@ const setupProgramsAndCourses = () => {
154154
{ results: [programB] },
155155
)
156156
setMockResponse.get(
157-
urls.courses.coursesList({ id: programA.courses, org_id: orgX.id }),
157+
urls.courses.coursesList({ id: programA.courses, org_id: orgX.id, page: 1 }),
158158
{
159159
results: coursesA.results,
160160
},
161161
)
162162
setMockResponse.get(
163-
urls.courses.coursesList({ id: programB.courses, org_id: orgX.id }),
163+
urls.courses.coursesList({ id: programB.courses, org_id: orgX.id, page: 1 }),
164164
{
165165
results: coursesB.results,
166166
},
@@ -262,6 +262,7 @@ function setupOrgDashboardMocks(
262262
mitxonline.urls.courses.coursesList({
263263
id: program.courses,
264264
org_id: org.id,
265+
page: 1,
265266
}),
266267
{ results: courses },
267268
)

frontends/main/src/app-pages/DashboardPage/OrganizationContent.test.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,8 @@ describe("OrganizationContent", () => {
144144
{ results: coursesB },
145145
)
146146

147+
console.log(coursesA, coursesB)
148+
147149
renderWithProviders(<OrganizationContent orgSlug={orgX.slug} />)
148150

149151
const collectionHeader = await screen.findByRole("heading", {
@@ -156,6 +158,7 @@ describe("OrganizationContent", () => {
156158
expect(collectionItems.length).toBe(1)
157159
const collection = within(collectionItems[0])
158160
expect(collection.getByText(programCollection.title)).toBeInTheDocument()
161+
console.log(collectionItems[0])
159162

160163
// Wait for the course data to load and check that courses are displayed
161164
await waitFor(() => {

frontends/main/src/app-pages/DashboardPage/OrganizationContent.tsx

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
"use client"
22

3-
import React, { useMemo } from "react"
3+
import React from "react"
44
import DOMPurify from "dompurify"
55
import Image from "next/image"
66
import { useFeatureFlagEnabled } from "posthog-js/react"
@@ -251,7 +251,10 @@ const OrgProgramDisplay: React.FC<{
251251
)
252252
const hasValidCertificate = !!programEnrollment?.certificate
253253
const courses = useInfiniteQuery(
254-
coursesQueries.coursesListInfinite({ id: program.courseIds, org_id: orgId }),
254+
coursesQueries.coursesListInfinite({
255+
id: program.courseIds,
256+
org_id: orgId,
257+
}),
255258
)
256259
const skeleton = (
257260
<Skeleton width="100%" height="65px" style={{ marginBottom: "16px" }} />
@@ -261,7 +264,7 @@ const OrgProgramDisplay: React.FC<{
261264
if (courses.hasNextPage && !courses.isFetching) courses.fetchNextPage()
262265

263266
const transformedCourses = transform.mitxonlineOrgCourses({
264-
courses: (() =>{
267+
courses: (() => {
265268
let courseData: Array<CourseWithCourseRunsSerializerV2> = []
266269

267270
for (const page of courses.data?.pages || []) {

0 commit comments

Comments
 (0)