Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no formatter for mjml files installed #56

Open
bldrdash opened this issue Nov 2, 2024 · 11 comments
Open

There is no formatter for mjml files installed #56

bldrdash opened this issue Nov 2, 2024 · 11 comments

Comments

@bldrdash
Copy link

bldrdash commented Nov 2, 2024

The release notes for version 2.0.0 suggests there is a way to enable beautifying, but I cannot find the correct settings to make this work. I currently have:

"[mjml]": {
    "editor.defaultFormatter": "mjmlio.vscode-mjml"
  },
  "mjml.beautify": {
    "indent_size": 2,
    "wrap_attributes_indent_size": 2
  },

What settings does version 2.0.0 require to beautify/format mjml documents?

Specifications

  • VS Code version: 1.95.1
  • MJML extension version: 2.0.0
@iRyusa
Copy link
Member

iRyusa commented Nov 2, 2024

That's my bad on this, while cleaning old command I wasn't aware that old beautifier was needed to format.

I'll try to make a PR as soon as I can to restore formatting.

@jonosheehy
Copy link

jonosheehy commented Nov 5, 2024

My coding skills don't extend beyond email code, so I was dismayed when I saw that version 2.0.0 removed the beautify command. I've spent some time trying to figure out how else I can beautify my MJML code, but didn't come up with anything within my current skills. So I will very much appreciate when 'MJML: Beautify' is restored please. 🙏 Thanks!

P.S. I've always thought that the 'Beautify MJML' functionality at https://mjml.io/try-it-live works pretty well.

@tnup
Copy link

tnup commented Dec 16, 2024

Hello @iRyusa , any news on this? My formatting is also broken using the latest version.

@iRyusa
Copy link
Member

iRyusa commented Dec 16, 2024

Trying to find time but as I'm quitting my current job it's a bit hard for me to find some 😅

@lgArlequin
Copy link

Any news?

@iRyusa
Copy link
Member

iRyusa commented Feb 20, 2025 via email

@lgArlequin
Copy link

lgArlequin commented Feb 20, 2025

Thanks!

Sorry if this is a dumb question, but does it update itself afterwards in the vscode marketplace?

@iRyusa
Copy link
Member

iRyusa commented Feb 20, 2025

In extension tab you'll see an update available

@iRyusa
Copy link
Member

iRyusa commented Feb 20, 2025

Can you check if the 2.1.0 works for you. It looks on my side I tried with racoon template ?

@lgArlequin
Copy link

lgArlequin commented Feb 20, 2025

It works with mjml, but now if you have a mj-style block with css it groups everything in one line

@iRyusa
Copy link
Member

iRyusa commented Feb 20, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants