-
Notifications
You must be signed in to change notification settings - Fork 943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Missing types #1240
Comments
I will make this a feature and leave it open. I think it's a good idea to have useful type hints for the stable Python API. |
I ran a quick Python script to see which files are missing type annotations, does this look right? |
I would only consider files in the subdirectory |
That makes sense - I've modified this here. I was just crawling https://github.com/AbhinavMir/mlx/blob/typeAnno/type_annotation_report.md |
I have added some type hints for few functions given in above file by @AbhinavMir Please let me know if they're right |
One of my friends @catplotlib wants to try Open Source, tagging her here so she can pick up a few type hints! |
I second the motion to add typings. |
I added #1345 for missing type hints in pip. |
The issue is partially solved through #1243. Since the PR is inactive for more than a month, I will be continuing the work and create a new pr for updated changes. |
* Solves issue #1240 * Correction * Update python/mlx/utils.py * Update python/mlx/utils.py --------- Co-authored-by: Awni Hannun <[email protected]> Co-authored-by: Awni Hannun <[email protected]>
There are many missing types in the library, with many functions having
Unknown
parameter or return types:I think it would be a great improvement to have full typing information across the MLX API.
The text was updated successfully, but these errors were encountered: