Skip to content

Finish implementation of MLC_ENABLE_SENTENCEPIECE_TOKENIZER #84

@WilliamTambellini

Description

@WilliamTambellini

There is a cmake option called MLC_ENABLE_SENTENCEPIECE_TOKENIZER but as today, when OFF, it does nt totally disable/skip sentencepiece, eg that line still links with the sentpiece lib:

target_link_libraries(tokenizers_cpp PRIVATE tokenizers_c sentencepiece-static ${TOKENIZERS_CPP_LINK_LIBS})

Would you mind if I add some small retouches to really fully disable sentpiece when that option is OFF?
Best regards
WT

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions