Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to fix TEST01 performance check #2072

Open
arjunsuresh opened this issue Feb 1, 2025 · 0 comments
Open

Need to fix TEST01 performance check #2072

arjunsuresh opened this issue Feb 1, 2025 · 0 comments

Comments

@arjunsuresh
Copy link
Contributor

This performance checker file for TEST01 has two main issues

  1. It has a lot of redundant code
  2. Regular expressions are used to extract performance value from the summary log instead of using mlperf log parser to extract the official performance value from the mlperf log detail like done by the submission checker. This also means, early stopping is not respected by the TEST01 check.

Since, the code freeze is in place, this can be a v5.0 postmortem item.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant