improve check on r6 cloneable

mllg · mllg · commit fdc4fd3a858e · 2017-10-18T14:59:43.000+02:00
diff --git a/R/checkR6.R b/R/checkR6.R
@@ -39,10 +39,10 @@ checkR6Props = function(x, cloneable = NULL, public = NULL, private = NULL) {
   if (!is.null(cloneable)) {
     qassert(cloneable, "B1")
     if (cloneable) {
-      if (is.null(x$clone))
+      if (!exists("clone", envir = x))
         return("Must be cloneable")
     } else {
-      if (!is.null(x$clone))
+      if (exists("clone", envir = x))
         return("May not be cloneable")
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -39,10 +39,10 @@ checkR6Props = function(x, cloneable = NULL, public = NULL, private = NULL) {`
`39`	`39`	`if (!is.null(cloneable)) {`
`40`	`40`	`qassert(cloneable, "B1")`
`41`	`41`	`if (cloneable) {`
`42`		`- if (is.null(x$clone))`
	`42`	`+ if (!exists("clone", envir = x))`
`43`	`43`	`return("Must be cloneable")`
`44`	`44`	`} else {`
`45`		`- if (!is.null(x$clone))`
	`45`	`+ if (exists("clone", envir = x))`
`46`	`46`	`return("May not be cloneable")`
`47`	`47`	`}`
`48`	`48`	`}`