From 0f8fa699ac1e85f01cacac42895f22f1cdc32430 Mon Sep 17 00:00:00 2001 From: mb706 Date: Tue, 15 Oct 2019 17:59:49 +0200 Subject: [PATCH] repr experiments --- DESCRIPTION | 2 ++ R/Learner.R | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/DESCRIPTION b/DESCRIPTION index 89bfb6d84..830c1f4c6 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -76,6 +76,8 @@ Suggests: rpart, testthat, titanic +Remotes: + mlr-org/mlr3misc@repr RdMacros: mlr3misc Encoding: UTF-8 LazyData: true diff --git a/R/Learner.R b/R/Learner.R index 70767b8b6..90acb9162 100644 --- a/R/Learner.R +++ b/R/Learner.R @@ -201,6 +201,7 @@ #' @family Learner #' @export Learner = R6Class("Learner", + inherit = Representable_In_Dict, public = list( id = NULL, state = NULL, @@ -216,7 +217,6 @@ Learner = R6Class("Learner", initialize = function(id, task_type, param_set = ParamSet$new(), predict_types = character(), feature_types = character(), properties = character(), data_formats = "data.table", packages = character(), man = NA_character_) { - self$id = assert_string(id, min.chars = 1L) self$task_type = assert_choice(task_type, mlr_reflections$task_types$type) private$.param_set = assert_param_set(param_set) @@ -228,6 +228,7 @@ Learner = R6Class("Learner", self$data_formats = assert_subset(data_formats, mlr_reflections$data_formats) self$packages = assert_set(packages) self$man = assert_string(man, na.ok = TRUE) + super$initialize() }, help = function() { @@ -353,6 +354,7 @@ Learner = R6Class("Learner", .encapsulate = NULL, .predict_type = NULL, .param_set = NULL, + .repr_dictionary = "lrn", deep_clone = function(name, value) { switch(name,