Change assumptions for FORMATTED UIA consoles

[codeofdusk]

NVDA 2021.3 contains changes to better work with a new version of the Windows Console. I haven't used your add-on, but a few assumptions about the UIA support made in the readme no longer hold:

• As of Refactor UiaTextRange For Improved Navigation and Reliability microsoft/terminal#4018 (IMPROVED API level in NVDA+f1 and the Cobalt inbox conhost), whitespace is not trimmed in UIA output.
• As of the FORMATTED API level (to be delivered in a Windows update), the console's output is no longer bounded to the visible text.

Does this violate any assumptions currently made by your add-on?

Cc @carlos-zamora (engineer working on UIA support on console side). I'm the person primarily responsible for the NVDA-side work. Thanks.

[mltony]

Not trimming the whitespaces is great - since I had to go into a great deal of hacking to work around this trimming. So I don't think this will break anything. But the fact that it will return all lines, not only the visible lines, this might break some functionality. I'll take a look at it when I have time. Thanks for flagging!

…

On 10/25/2021 4:00 PM, Bill Dengler wrote: NVDA 2021.3 contains changes to better work with a new version of the Windows Console <https://codeofdusk.com/ConsoleTestPackage_2021-10-22.zip>. I haven't used your add-on, but a few assumptions about the UIA support made in the readme no longer hold: * As of microsoft/terminal#4018 <microsoft/terminal#4018> (|IMPROVED| API level in NVDA+f1 and the Cobalt inbox conhost), whitespace is not trimmed in UIA output. * As of the |FORMATTED| API level (to be delivered in a Windows update), the console's output is no longer bounded to the visible text. Does this violate any assumptions currently made by your add-on? Cc @carlos-zamora <https://github.com/carlos-zamora> (engineer working on UIA support on console side). I'm the person primarily responsible for the NVDA-side work. Thanks. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#2>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIJRDHEOLZKWCEPBQBM6JR3UIXOPPANCNFSM5GWMIL5A>. Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[codeofdusk]

FYI, when you're working on this:

from _UIAConstants import WinConsoleAPILevel

# obj represents an NVDAObjects.UIA.WinConsoleUIA.WinConsoleUIA instance
if obj.apiLevel >= WinConsoleAPILevel.IMPROVED:
    # This console has whitespaces
if obj.apiLevel >= WinConsoleAPILevel.FORMATTED:
    # This console allows free exploration of the text buffer

You can also see the API level that a console has in the NVDA+f1 log (currently the last line of output).