Skip to content

Commit 123a416

Browse files
committed
Change OpenJDK repo and dir names back to openjdk
We revert to our old repository and directory name `openjdk` instead of `jdk`. - The upstream OpenJDK project creates one repository for every major release, such as `jdk21u`, and updates to that major versions are pushed into that repository. The `jdk` repository is for the main line development. Since our `openjdk` repo actually follows update repos (such as `jdk21u`), it doesn't make sense to use `jdk` as the repository name. - There are many other JVM implementations out there, such as JikesRVM and OpenJ9. Using the repository name `openjdk` emphasizes that it is OpenJDK.
1 parent f5defe3 commit 123a416

File tree

3 files changed

+12
-12
lines changed

3 files changed

+12
-12
lines changed

.github/scripts/common.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ RUSTUP_TOOLCHAIN=`cat $BINDING_PATH/mmtk/rust-toolchain`
33

44
# build.yml specifies the OPENJDK_PATH env var when calling ci-build.sh
55
# But other scripts expect a default path for OpenJDK.
6-
OPENJDK_PATH=${OPENJDK_PATH:="$BINDING_PATH/repos/jdk"}
6+
OPENJDK_PATH=${OPENJDK_PATH:="$BINDING_PATH/repos/openjdk"}
77

88
# dacapo2006 min heap for mark compact
99
MINHEAP_ANTLR=5

README.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ Your working directory/
3535
├─ mmtk-openjdk/
3636
│ ├─ openjdk/
3737
│ └─ mmtk/
38-
├─ jdk/
38+
├─ openjdk/
3939
└─ mmtk-core/ (optional)
4040
```
4141

@@ -52,13 +52,13 @@ The binding repo mainly consists of two folders, `mmtk` and `openjdk`.
5252

5353
#### Checkout OpenJDK
5454

55-
You would need our OpenJDK fork which includes the support for a third party heap (like MMTk). We assume you put `jdk` as a sibling of `mmtk-openjdk`.
55+
You would need our OpenJDK fork which includes the support for a third party heap (like MMTk). We assume you put `openjdk` as a sibling of `mmtk-openjdk`.
5656
[`Cargo.toml`](mmtk/Cargo.toml) defines the version of OpenJDK that works with the version of `mmtk-openjdk`.
5757

5858
Assuming your current working directory is the parent folder of `mmtk-openjdk`, you can checkout out OpenJDK and the correct version using:
5959
```console
60-
$ git clone https://github.com/mmtk/jdk.git
61-
$ git -C jdk checkout `sed -n 's/^openjdk_version.=."\(.*\)"$/\1/p' < mmtk-openjdk/mmtk/Cargo.toml`
60+
$ git clone https://github.com/mmtk/openjdk.git
61+
$ git -C openjdk checkout `sed -n 's/^openjdk_version.=."\(.*\)"$/\1/p' mmtk-openjdk/mmtk/Cargo.toml`
6262
```
6363

6464
#### Checkout MMTk core (optional)
@@ -86,7 +86,7 @@ _**Note:** MMTk is only tested with the `server` build variant._
8686
After cloned the OpenJDK repo, cd into the root directiory:
8787

8888
```console
89-
$ cd jdk
89+
$ cd openjdk
9090
```
9191

9292
Then select a `DEBUG_LEVEL`, can be one of `release`, `fastdebug`, `slowdebug` and `optimized`.
@@ -117,11 +117,11 @@ Then build OpenJDK (this will build MMTk as well):
117117
$ make CONF=linux-x86_64-server-release THIRD_PARTY_HEAP=$PWD/../mmtk-openjdk/openjdk images
118118
```
119119

120-
The output jdk is then found at `./build/linux-x86_64-server-release/images/jdk`.
120+
The output JDK is then found at `./build/linux-x86_64-server-release/images/jdk`.
121121

122122
> **Note:** The above `make` command will build the `images` target, which is a proper release build of OpenJDK. It is **essential** that you use this target if you are planning on evaluating your build (e.g. measuring performance, gathering minimum heap values, etc). However, if you are simply developing and building incremental changes often, you may want to use the [`default` target or "exploded image"](https://github.com/openjdk/jdk21u/blob/master/doc/building.md#Running-make), which has a marginally shorter build time. However, be wary, as the exploded image is the (roughly) minimal set of outputs required to run the built JDK and is not guaranteed to run all benchmarks. It may have bloated minimum heap values as well.
123-
>
124-
> The exploded image can be built as follows. The output jdk can be found at `./build/linux-x86_64-server-$DEBUG_LEVEL/jdk`.
123+
124+
> The exploded image can be built as follows. The output JDK can be found at `./build/linux-x86_64-server-$DEBUG_LEVEL/jdk`.
125125
>
126126
> ```console
127127
> $ make CONF=linux-x86_64-server-$DEBUG_LEVEL THIRD_PARTY_HEAP=$PWD/../mmtk-openjdk/openjdk

mmtk/Cargo.toml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@ lto = true
1616

1717
# Metadata for the OpenJDK repository
1818
[package.metadata.openjdk]
19-
# Our CI matches the following line and extract mmtk/jdk. If this line is updated, please check ci yaml files and make sure it works.
20-
openjdk_repo = "https://github.com/mmtk/jdk.git"
21-
openjdk_version = "2632c4f7b5366bed4d0cb91ea5ffe93541a70e30"
19+
# Our CI matches the following line and extract mmtk/openjdk. If this line is updated, please check ci yaml files and make sure it works.
20+
openjdk_repo = "https://github.com/mmtk/openjdk.git"
21+
openjdk_version = "b557520f04b35d2a7a040d43f02efc1c4911ebb7"
2222

2323
[dependencies]
2424
libc = "0.2"

0 commit comments

Comments
 (0)