Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of gocovmerge is problematic #5608

Open
tonistiigi opened this issue Dec 19, 2024 · 0 comments
Open

Usage of gocovmerge is problematic #5608

tonistiigi opened this issue Dec 19, 2024 · 0 comments

Comments

@tonistiigi
Copy link
Member

The test stages run through https://github.com/wadey/gocovmerge project installed in https://github.com/moby/buildkit/blob/v0.18.2/Dockerfile#L300 .

This is problematic because this project:

  • Does not have a go.mod
  • Does not have any tags
  • Has not received changes in 9 years

The combination of these issues means that we are not able to run tests in old versions anymore as go install will fail, for example, already in go1.21.

docker run -it --rm golang:1.21-alpine

/go # go install "github.com/wadey/gocovmerge@latest"
go: downloading github.com/wadey/gocovmerge v0.0.0-20160331181800-b5bfa59ec0ad
go: finding module for package golang.org/x/tools/cover
go: downloading golang.org/x/tools v0.28.0
go: toolchain upgrade needed to resolve golang.org/x/tools/cover
go: golang.org/x/[email protected] requires go >= 1.22.0 (running go 1.21.13; GOTOOLCHAIN=local)

This will continue happening for our current releases as well. As Go (and x/tools) gets updated, or tests stop working.

We need to either:

  • Move away from this project
  • Create a fork with go.mod support and commits with pinned minimal go versions.

cc @crazy-max

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant