Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Example: Add Express.js tests for body and headers #57

Open
amlannandy opened this issue May 29, 2022 · 3 comments
Open

🚀 Example: Add Express.js tests for body and headers #57

amlannandy opened this issue May 29, 2022 · 3 comments
Labels
area: examples status: accepting prs Please, send a pull request to resolve this! 🙏 type: feature New feature or request

Comments

@amlannandy
Copy link

Add more examples for the express-rest-api package, preferably handling more methods such as POST and covering more scenarios for testing (missing fields in req body, headers etc).

@amlannandy
Copy link
Author

Raised this issue as I thought having just one basic test isn't enough.
Unless there's some other source for getting examples now and this repo isn't being maintained anymore? Let me know if that's the case.
I can raise a PR with some more examples if the maintainers think it's necessary.

@JoshuaKGoldberg
Copy link
Member

👋 hi @amlannandy! Per mochajs/mocha#5027 there's now an active maintenance team that can look at these things. Are you still interested in this?

Personally I think it'd make a lot of sense to have an example test added to check a request's body, and an example test for checking a request's headers.

@JoshuaKGoldberg JoshuaKGoldberg added type: feature New feature or request status: accepting prs Please, send a pull request to resolve this! 🙏 area: examples labels Jul 4, 2024
@JoshuaKGoldberg JoshuaKGoldberg changed the title Add more examples for Express.js 🚀 Examples: Add Express.js tests for body and headers Jul 4, 2024
@JoshuaKGoldberg JoshuaKGoldberg changed the title 🚀 Examples: Add Express.js tests for body and headers 🚀 Example: Add Express.js tests for body and headers Jul 4, 2024
@amlannandy
Copy link
Author

Hi @JoshuaKGoldberg
Sure I can pick it up! It's been a while so it might take me some time to catch up with the context. But I'll keep you updated on this thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: examples status: accepting prs Please, send a pull request to resolve this! 🙏 type: feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants