Replace 'rackup' with 'rack' in server file #177
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running this example with Ruby 3.4.5 the following does not work:
```ruby
Rackup::Handler.get("puma").run(rack_app, Port: 9393, Host: "0.0.0.0")
```
It returns the following error message:
`uninitialized constant Rackup::Handler (NameError)`
To resolve this I just required Rack and changed Rackup to Rack. Then things worked fine.
Member
|
Hm, the issue doesn't reproduce with the following steps. First, start the server in a terminal: $ cd path/to/ruby-sdk
$ ruby examples/streamable_http_server.rbThen, in another terminal, run the client: $ cd path/to/ruby-sdk
$ ruby examples/streamable_http_client.rbCan you share the steps to reproduce the error reported in this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Running this example with Ruby 3.4.5 the following does not work:
It returns the following error message:
uninitialized constant Rackup::Handler (NameError)To resolve this I just required Rack and changed Rackup to Rack. Then things worked fine.
How Has This Been Tested?
I was running this in development mode to help me understand the use of the gem and ran into this issue.
Breaking Changes
There shouldn't be any breaking changes
Types of changes
Checklist
Additional context