fix: clippy warnings and formatting

Author: Brandon Bennett

crates/rmcp-macros/src/skill.rs

@@ -45,7 +45,7 @@ impl ResolvedSkillAttribute {
             description,
             dynamic,
         } = self;
-        let description = if let Some(description) = description {
+        let _description = if let Some(description) = description {
             quote! { Some(#description.into()) }
         } else {
             quote! { None }
@@ -149,13 +149,13 @@ pub fn skill(attr: TokenStream, input: TokenStream) -> syn::Result<TokenStream>
         let omit_send = cfg!(feature = "local") || attribute.local;
         let new_output = syn::parse2::<ReturnType>({
             let mut lt = quote! { 'static };
-            if let Some(receiver) = fn_item.sig.receiver() {
-                if let syn::ReceiverKind::Reference(_, receiver_lt, _) = &receiver.kind {
-                    if let Some(receiver_lt) = receiver_lt {
-                        lt = quote! { #receiver_lt };
-                    } else {
-                        lt = quote! { '_ };
-                    }
+            if let Some(receiver) = fn_item.sig.receiver()
+                && let syn::ReceiverKind::Reference(_, receiver_lt, _) = &receiver.kind
+            {
+                if let Some(receiver_lt) = receiver_lt {
+                    lt = quote! { #receiver_lt };
+                } else {
+                    lt = quote! { '_ };
                 }
             }
             match &fn_item.sig.output {

crates/rmcp-macros/src/skill_handler.rs

@@ -1,7 +1,7 @@
 use darling::{FromMeta, ast::NestedMeta};
 use proc_macro2::TokenStream;
-use quote::{ToTokens, format_ident, quote};
-use syn::{Expr, ImplItem, ItemImpl, parse_quote};
+use quote::{ToTokens, quote};
+use syn::{Expr, ImplItem, ItemImpl};
 
 use crate::common::{has_method, has_sibling_handler};
 
@@ -82,7 +82,7 @@ pub fn skill_handler(attr: TokenStream, input: TokenStream) -> syn::Result<Token
     let attr_args = NestedMeta::parse_meta_list(attr)?;
     let SkillHandlerAttribute {
         router,
-        meta,
+        meta: _,
         name,
         version,
         instructions,
@@ -186,17 +186,15 @@ pub fn skill_handler(attr: TokenStream, input: TokenStream) -> syn::Result<Token
         item_impl.items.push(directory_read_fn);
     }
 
-    if !has_method("get_info", &item_impl) {
-        if !has_sibling_handler(&item_impl, "tool_handler") {
-            let get_info_fn = build_get_info(
-                &item_impl,
-                name,
-                version,
-                instructions,
-                CallerCapability::Skills,
-            )?;
-            item_impl.items.push(get_info_fn);
-        }
+    if !has_method("get_info", &item_impl) && !has_sibling_handler(&item_impl, "tool_handler") {
+        let get_info_fn = build_get_info(
+            &item_impl,
+            name,
+            version,
+            instructions,
+            CallerCapability::Skills,
+        )?;
+        item_impl.items.push(get_info_fn);
     }
 
     Ok(item_impl.into_token_stream())

crates/rmcp/examples/skill_fs_server.rs

@@ -52,10 +52,10 @@ impl FileSystemSkillServer {
             let path = entry.path();
             if path.is_dir() {
                 Self::walk_dir(root, &path, skills)?;
-            } else if path.file_name().and_then(|s| s.to_str()) == Some(SKILL_FILE) {
-                if let Some(skill) = Self::parse_skill_file(root, &path) {
-                    skills.insert(skill.uri.clone(), skill);
-                }
+            } else if path.file_name().and_then(|s| s.to_str()) == Some(SKILL_FILE)
+                && let Some(skill) = Self::parse_skill_file(root, &path)
+            {
+                skills.insert(skill.uri.clone(), skill);
             }
         }
         Ok(())

crates/rmcp/src/handler/server/router.rs

@@ -163,7 +163,7 @@ where
                 Ok(ServerResult::SkillsListResult(
                     crate::model::skills::SkillsListResult {
                         result_type: Some(crate::model::ResultType::COMPLETE),
-                        skills: skills.into_iter().map(|s| s.into()).collect(),
+                        skills: skills.into_iter().collect(),
                         next_cursor: None,
                         ttl_ms: None,
                         cache_scope: None,
@@ -187,7 +187,7 @@ where
                         .await
                 }
             }
-            ClientRequest::ResourcesDirectoryReadRequest(request) => {
+            ClientRequest::ResourcesDirectoryReadRequest(_request) => {
                 let result = crate::model::skills::ResourcesDirectoryReadResult {
                     result_type: Some(crate::model::ResultType::COMPLETE),
                     children: vec![],

crates/rmcp/src/handler/server/router/skill.rs

@@ -10,8 +10,8 @@ use std::{borrow::Cow, sync::Arc};
 
 use crate::{
     handler::server::skill::{CallSkillHandler, DynCallSkillHandler, SkillCallContext},
-    model::skills::{SkillEntry, SkillResources},
-    service::{MaybeBoxFuture, MaybeSend},
+    model::skills::SkillEntry,
+    service::MaybeSend,
 };
 
 #[non_exhaustive]

crates/rmcp/src/handler/server/skill.rs

@@ -7,7 +7,7 @@
 
 use crate::{
     model::skills::SkillEntry,
-    service::{MaybeBoxFuture, MaybeSend, RequestContext, RoleServer},
+    service::{MaybeBoxFuture, RequestContext, RoleServer},
 };
 
 /// Context passed to a skill handler when invoked.

crates/rmcp/tests/test_skills_conformance.rs

@@ -15,8 +15,6 @@ use std::{
     process::{Command, Stdio},
 };
 
-use rmcp::model::skills::{self, SkillResources};
-
 fn skills_dir() -> std::path::PathBuf {
     let manifest_dir = std::env::var("CARGO_MANIFEST_DIR").unwrap_or_else(|_| ".".to_string());
     let crate_root = std::path::PathBuf::from(manifest_dir);