Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-server] Configure what browser should be used when --open is used. #2805

Open
Pieterv24 opened this issue Sep 12, 2024 · 0 comments
Open

Comments

@Pieterv24
Copy link
Contributor

I would like a way to configure what browser should be used when the --open parameter is passed.
This can be handy for creating different (manual) test scenarios quickly with scripts.

I saw that in /packages/dev-server/src/openBrowser.ts the "open" package is used to open the browser window.
This package supports more configuration when opening a browser window.

I would say the easiest approach here, is to add a new field to the DevServerConfig which contains the needed information.

The open package has an apps export, which is either: 'chrome', 'firefox', 'edge', 'browser' or 'browserPrivate' we could probably do some type checking/input validation based on this.
Additionally the openBrowserWindow function can take arguments, for example '--incognito' this would also be a nice to have in my opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant