Fix user deletion with new notifications_deliveries table for real (#4473)

Maybe this will work? I dunno but users are still saying they're getting errors deleting accs. In theory it shouldn't matter if the transaction all gets committed at the same time, though, right? I can't really test this so I would like someone to tell me whether this will actually make a difference.

Co-authored-by: François-X. T <[email protected]>

Author: triphora

apps/labrinth/src/database/models/user_item.rs

@@ -561,18 +561,18 @@ impl DBUser {
 
             sqlx::query!(
                 "
-                DELETE FROM notifications
-                WHERE user_id = $1
+                DELETE FROM notifications_actions
+                 WHERE notification_id = ANY($1)
                 ",
-                id as DBUserId,
+                &notifications
             )
             .execute(&mut **transaction)
             .await?;
 
             sqlx::query!(
                 "
-                DELETE FROM notifications_actions
-                 WHERE notification_id = ANY($1)
+                DELETE FROM notifications_deliveries
+                WHERE notification_id = ANY($1)
                 ",
                 &notifications
             )
@@ -581,10 +581,10 @@ impl DBUser {
 
             sqlx::query!(
                 "
-                DELETE FROM notifications_deliveries
-                WHERE notification_id = ANY($1)
+                DELETE FROM notifications
+                WHERE user_id = $1
                 ",
-                &notifications
+                id as DBUserId,
             )
             .execute(&mut **transaction)
             .await?;