Modrinth Hosting rebrand #4846
Merged
Modrinth Hosting rebrand #4846
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IMB11
reviewed
Dec 3, 2025
IMB11
requested changes
Dec 3, 2025
Member
There was a problem hiding this comment.
- If a user clicks "Select plan" when logged out, the auth redirect url sends them to /servers?plan=<plan_here> which doesn't redirect properly because of the middleware not respecting query params (either update the url or fix the middleware)
- In the purchase modal, it still says "Modrinth servers" when you're in the final preview of the transaction
- My servers may be confusing in the future in profile navbar? nitpick
IMB11
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.