[stdlib] Change Span._len to UInt
#4294
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinvuyk
force-pushed
the
change-span-length-uint
branch
4 times, most recently
from
c7345b7 to
5139e64
Compare
Signed-off-by: martinvuyk <[email protected]>
martinvuyk
force-pushed
the
change-span-length-uint
branch
from
5139e64 to
4ee171e
Compare
|
FYI, this isn't your fault, but I don't agree with this line of changes. We want a single common "currency" type for "integers the size of pointers". That type is called Int for a wide range of reasons. We should us it, instead of UInt. Let's talk offline and get something we can document in the stdlib manual. Swift went through all of this years ago and it was a hard won lesson, but after doing it, it was clearly the right path. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4283