[stdlib] [NFC] Replace _strnlen with _unsafe_strlen(ptr, max: UInt = UInt.MAX)
#4306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soraros
reviewed
Apr 6, 2025
soraros
reviewed
Apr 6, 2025
martinvuyk
force-pushed
the
centralize-strlen-impls-and-make-safe
branch
3 times, most recently
from
7726c53 to
ffe9887
Compare
soraros
reviewed
Apr 15, 2025
martinvuyk
force-pushed
the
centralize-strlen-impls-and-make-safe
branch
from
2062d66 to
9406f11
Compare
martinvuyk
force-pushed
the
centralize-strlen-impls-and-make-safe
branch
4 times, most recently
from
becf5ec to
f46c599
Compare
|
I suggest removing the |
martinvuyk
force-pushed
the
centralize-strlen-impls-and-make-safe
branch
from
f46c599 to
260acf2
Compare
martinvuyk
changed the title
_strnlen to string_slice.mojo and make _unsafe_strlen a bit safer_strnlen with _unsafe_strlen(ptr, max: UInt = UInt.MAX)
soraros
reviewed
May 17, 2025
martinvuyk
force-pushed
the
centralize-strlen-impls-and-make-safe
branch
2 times, most recently
from
b0f717e to
1de496f
Compare
kartva
approved these changes
Aug 21, 2025
Signed-off-by: martinvuyk <[email protected]>
martinvuyk
force-pushed
the
centralize-strlen-impls-and-make-safe
branch
from
1de496f to
e3425d7
Compare
|
!sync |
modularbot
added
the
imported-internally
|
✅🟣 This contribution has been merged 🟣✅ Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the main branch during the next Mojo nightly release, typically within the next 24-48 hours. We use Copybara to merge external contributions, click here to learn more. |
modularbot
added
merged-internally
|
Landed in b1378c8! Thank you for your contribution 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
_strnlenwith_unsafe_strlen(ptr, max: UInt = UInt.MAX)